From: Kalle Valo <kvalo@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [for-4.12, 3/3] brcmfmac: unbind all devices upon failure in firmware callback
Date: Tue, 13 Jun 2017 06:12:35 +0000 (UTC) [thread overview]
Message-ID: <20170613061235.E0D89607C4@smtp.codeaurora.org> (raw)
In-Reply-To: <1497268054-4507-4-git-send-email-arend.vanspriel@broadcom.com>
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> In brcmf_sdio_firmware_callback() we need to unbind the driver from
> both sdio_func devices.
>
> Cc: stable@vger.kernel.org # 4.9.x-
> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
The commit log doesn't really describe the bug you are fixing (ie. doesn't
answer "why?"). Can you give some more info, logs etc (as a reply to this mail)
and I'll add it.
--
https://patchwork.kernel.org/patch/9780797/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-06-13 6:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 11:47 [PATCH for-4.12 0/3] brcmfmac: fix sdio suspend crash due to firmware load failure Arend van Spriel
2017-06-12 11:47 ` [PATCH for-4.12 1/3] brcmfmac: add parameter to pass error code in firmware callback Arend van Spriel
2017-06-15 16:08 ` [for-4.12, " Kalle Valo
2017-06-15 16:17 ` [PATCH for-4.12 " Kalle Valo
2017-06-12 11:47 ` [PATCH for-4.12 2/3] brcmfmac: use firmware callback upon failure to load Arend van Spriel
2017-06-12 11:47 ` [PATCH for-4.12 3/3] brcmfmac: unbind all devices upon failure in firmware callback Arend van Spriel
2017-06-13 6:12 ` Kalle Valo [this message]
[not found] ` <20170613061235.D11C6607CC@smtp.codeaurora.org>
2017-06-13 11:36 ` [for-4.12, " Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613061235.E0D89607C4@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).