linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Samuel Ortiz <sameo@linux.intel.com>,
	linux-wireless@vger.kernel.org, linux-nfc@lists.01.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 02/13] NFC: st21nfca: Add GPIO ACPI mapping table
Date: Mon, 19 Jun 2017 13:08:47 +0300	[thread overview]
Message-ID: <20170619100858.2655-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170619100858.2655-1-andriy.shevchenko@linux.intel.com>

In order to make GPIO ACPI library stricter prepare users of
gpiod_get_index() to correctly behave when there no mapping is
provided by firmware.

Here we add explicit mapping between _CRS GpioIo() resources and
their names used in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/nfc/st21nfca/i2c.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
index 4bff76baa341..3621290807f6 100644
--- a/drivers/nfc/st21nfca/i2c.c
+++ b/drivers/nfc/st21nfca/i2c.c
@@ -501,14 +501,25 @@ static struct nfc_phy_ops i2c_phy_ops = {
 	.disable = st21nfca_hci_i2c_disable,
 };
 
+static const struct acpi_gpio_params enable_gpios = { 1, 0, false };
+
+static const struct acpi_gpio_mapping acpi_st21nfca_gpios[] = {
+	{ "enable-gpios", &enable_gpios, 1 },
+	{},
+};
+
 static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client)
 {
 	struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client);
 	struct device *dev = &client->dev;
+	int ret;
+
+	ret = devm_acpi_dev_add_driver_gpios(dev, acpi_st21nfca_gpios);
+	if (ret)
+		return ret;
 
 	/* Get EN GPIO from ACPI */
-	phy->gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1,
-					      GPIOD_OUT_LOW);
+	phy->gpiod_ena = devm_gpiod_get(dev, ST21NFCA_GPIO_NAME_EN, GPIOD_OUT_LOW);
 	if (IS_ERR(phy->gpiod_ena)) {
 		nfc_err(dev, "Unable to get ENABLE GPIO\n");
 		return PTR_ERR(phy->gpiod_ena);
@@ -523,8 +534,7 @@ static int st21nfca_hci_i2c_of_request_resources(struct i2c_client *client)
 	struct device *dev = &client->dev;
 
 	/* Get GPIO from device tree */
-	phy->gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 0,
-					      GPIOD_OUT_HIGH);
+	phy->gpiod_ena = devm_gpiod_get(dev, ST21NFCA_GPIO_NAME_EN, GPIOD_OUT_HIGH);
 	if (IS_ERR(phy->gpiod_ena)) {
 		nfc_err(dev, "Failed to request enable pin\n");
 		return PTR_ERR(phy->gpiod_ena);
-- 
2.11.0

  parent reply	other threads:[~2017-06-19 10:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 10:08 [PATCH v3 00/13] NFC: clean up for ACPI GPIO usage Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 01/13] NFC: pn544: Switch to devm_acpi_dev_add_driver_gpios() Andy Shevchenko
2017-06-19 10:08 ` Andy Shevchenko [this message]
2017-06-19 10:08 ` [PATCH v3 03/13] NFC: st21nfca: Get rid of code duplication in ->probe() Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 04/13] NFC: fdp: Convert I2C driver to ->probe_new() Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 05/13] NFC: fdp: Convert to use devres API Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 06/13] NFC: fdp: Add GPIO ACPI mapping table Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 07/13] NFC: st-nci: Get rid of platform data Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 08/13] NFC: st-nci: Get rid of "interesting" use of interrupt polarity Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 09/13] NFC: st-nci: Covert to use GPIO descriptor Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 10/13] NFC: st-nci: Use unified device properties API meaningfully Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 11/13] NFC: st-nci: Add GPIO ACPI mapping table Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 12/13] NFC: st-nci: Get rid of code duplication in ->probe() Andy Shevchenko
2017-06-19 10:08 ` [PATCH v3 13/13] MAINTAINERS: Remove non-existing NFC platform data files Andy Shevchenko
2017-06-22 21:55 ` [PATCH v3 00/13] NFC: clean up for ACPI GPIO usage Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619100858.2655-3-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-nfc@lists.01.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).