From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Birming Chiu <birming@realtek.com>, Shaofu <shaofu@realtek.com>,
Steven Ting <steventing@realtek.com>
Subject: Re: [07/10] rtlwifi: Fill ap_num filed by vendor command
Date: Wed, 21 Jun 2017 15:17:20 +0000 (UTC) [thread overview]
Message-ID: <20170621151721.0052060A4F@smtp.codeaurora.org> (raw)
In-Reply-To: <20170620003218.17010-8-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> The ap_num can be filled by wpa_cli's VENDOR command.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Cc: Birming Chiu <birming@realtek.com>
> Cc: Shaofu <shaofu@realtek.com>
> Cc: Steven Ting <steventing@realtek.com>
This is a perfect example why I have been against vendor commands in the past.
I already regret changing my mind...
If you want me to seriously consider taking a patch adding a vendor command I
need GOOD justifications why a normal nl80211 command is not suitable and which
are properly documented in the commit log. One sentence definitely
is not enough.
Larry, please drop all patches related to vendor commands in this patch and
resend. Adding vendor commands should be in a separate patchset so it can be
discussed without blocking anything else.
--
https://patchwork.kernel.org/patch/9798295/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-06-21 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 0:32 [PATCH 00/10] Set 2 of changes related to updates of btcoexist Larry Finger
2017-06-20 0:32 ` [PATCH 01/10] rtlwifi: Fix a2dp choppy while BT RSSI stays on threshold Larry Finger
2017-06-20 0:32 ` [PATCH 02/10] rtlwifi: Do IQK only once to reduce wifi occupy antenna Larry Finger
2017-06-20 0:32 ` [PATCH 03/10] rtlwifi: Modify power mode parameters of 8723be and 8821ae Larry Finger
2017-06-20 0:32 ` [PATCH 04/10] rtlwifi: Update some cases in btc_get function -- roam, 5G, AP mode, and return value Larry Finger
2017-06-20 0:32 ` [PATCH 05/10] rtlwifi: Add return value to btc_set Larry Finger
2017-06-20 0:32 ` [PATCH 06/10] rtlwifi: Add ap_num field for btcoexist Larry Finger
2017-06-20 0:32 ` [PATCH 07/10] rtlwifi: Fill ap_num filed by vendor command Larry Finger
2017-06-21 15:17 ` Kalle Valo [this message]
2017-06-20 0:32 ` [PATCH 08/10] rtlwifi: Fill ap_num field by driver Larry Finger
2017-06-20 0:32 ` [PATCH 09/10] rtlwifi: Add in_4way field for btcoexist Larry Finger
2017-06-20 0:32 ` [PATCH 10/10] rtlwifi: Fill in_4way field by vendor command Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621151721.0052060A4F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=birming@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=shaofu@realtek.com \
--cc=steventing@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).