[PATCH] mwifiex: Do not change bss_type in change_virtual_intf

[PATCH] mwifiex: Do not change bss_type in change_virtual_intf

[Ganapathi Bhat]

When user adds a virtual interface driver will set the
bss_type to the iface_type given by the user. When
supplicant is started on the same interface, a call to
change_virtual_intf will be triggered if if_type is not
NL80211_IFTYPE_STATION. Here driver should not update
it's bss_type, because bss_type is intended to indicate
the original iface_type and changing the same will defeat
the purpose of creating this interface.

Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 6ecbcbd..2239d8f 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -875,24 +875,20 @@ static int mwifiex_deinit_priv_params(struct mwifiex_private *priv)
 		priv->bss_num = mwifiex_get_unused_bss_num(adapter,
 			 MWIFIEX_BSS_TYPE_STA);
 		priv->bss_role =  MWIFIEX_BSS_ROLE_STA;
-		priv->bss_type = MWIFIEX_BSS_TYPE_STA;
 		break;
 	case NL80211_IFTYPE_P2P_CLIENT:
 		priv->bss_num = mwifiex_get_unused_bss_num(adapter,
 			 MWIFIEX_BSS_TYPE_P2P);
 		priv->bss_role =  MWIFIEX_BSS_ROLE_STA;
-		priv->bss_type = MWIFIEX_BSS_TYPE_P2P;
 		break;
 	case NL80211_IFTYPE_P2P_GO:
 		priv->bss_num = mwifiex_get_unused_bss_num(adapter,
 			 MWIFIEX_BSS_TYPE_P2P);
 		priv->bss_role =  MWIFIEX_BSS_ROLE_UAP;
-		priv->bss_type = MWIFIEX_BSS_TYPE_P2P;
 		break;
 	case NL80211_IFTYPE_AP:
 		priv->bss_num = mwifiex_get_unused_bss_num(adapter,
 			 MWIFIEX_BSS_TYPE_UAP);
-		priv->bss_type = MWIFIEX_BSS_TYPE_UAP;
 		priv->bss_role = MWIFIEX_BSS_ROLE_UAP;
 		break;
 	default:
-- 
1.9.1

Re: mwifiex: Do not change bss_type in change_virtual_intf

[Kalle Valo]

Ganapathi Bhat <gbhat@marvell.com> wrote:

> When user adds a virtual interface driver will set the
> bss_type to the iface_type given by the user. When
> supplicant is started on the same interface, a call to
> change_virtual_intf will be triggered if if_type is not
> NL80211_IFTYPE_STATION. Here driver should not update
> it's bss_type, because bss_type is intended to indicate
> the original iface_type and changing the same will defeat
> the purpose of creating this interface.
> 
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>

Patch applied to wireless-drivers-next.git, thanks.

4d7ab36f0c47 mwifiex: Do not change bss_type in change_virtual_intf

-- 
https://patchwork.kernel.org/patch/9803591/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches