From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: libertas: Fix lbs_prb_rsp_limit_set()
Date: Wed, 28 Jun 2017 18:18:22 +0000 (UTC) [thread overview]
Message-ID: <20170628181822.742BF60AD6@smtp.codeaurora.org> (raw)
In-Reply-To: <20170623151738.qxncismrvd4yzzfr@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
>
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: James Cameron <quozl@laptop.org>
>
> diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
> index eeeb892219aa..37ace5cb309d 100644
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
> memset(&mesh_access, 0, sizeof(mesh_access));
> mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
>
> - if (!kstrtoul(buf, 10, &retry_limit))
> - return -ENOTSUPP;
> + ret = kstrtoul(buf, 10, &retry_limit);
> + if (ret)
> + return ret;
> if (retry_limit > 15)
> return -ENOTSUPP;
Patch applied to wireless-drivers-next.git, thanks.
69551f5f370c libertas: Fix lbs_prb_rsp_limit_set()
--
https://patchwork.kernel.org/patch/9806775/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-06-28 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 15:17 [PATCH] libertas: Fix lbs_prb_rsp_limit_set() Dan Carpenter
2017-06-23 20:22 ` James Cameron
2017-06-28 18:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628181822.742BF60AD6@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=jg1.han@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).