From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luca@coelho.fi>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
arend.vanspriel@broadcom.com,
Andrei Otcheretianski <andrei.otcheretianski@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [v2] nl80211: Don't verify owner_nlportid on NAN commands
Date: Fri, 30 Jun 2017 06:47:13 +0000 (UTC) [thread overview]
Message-ID: <20170630064713.5F0EE607EA@smtp.codeaurora.org> (raw)
In-Reply-To: <20170626165230.13971-1-luca@coelho.fi>
Luciano Coelho <luca@coelho.fi> wrote:
> From: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
>
> If NAN interface is created with NL80211_ATTR_SOCKET_OWNER, the socket
> that is used to create the interface is used for all NAN operations and
> reporting NAN events.
> However, it turns out that sending commands and receiving events on
> the same socket is not possible in a completely race-free way:
> If the socket buffer is overflowed by the events, the command response
> will not be sent. In that case the caller will block forever on recv.
> Using non-blocking socket for commands is more complicated and still
> the command response or ack may not be received.
> So, keep unicasting NAN events to the interface creator, but allow
> using a different socket for commands.
>
> Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Patch applied to wireless-drivers-next.git, thanks.
36a554cec119 nl80211: Don't verify owner_nlportid on NAN commands
--
https://patchwork.kernel.org/patch/9810107/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-06-30 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 16:52 [PATCH v2] nl80211: Don't verify owner_nlportid on NAN commands Luca Coelho
2017-06-27 12:03 ` Arend van Spriel
2017-06-27 12:12 ` Otcheretianski, Andrei
2017-06-29 13:24 ` Johannes Berg
2017-06-30 6:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630064713.5F0EE607EA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=andrei.otcheretianski@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).