Linux wireless drivers development
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kbuild-all@01.org, kvalo@codeaurora.org,
	linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Birming Chiu <birming@realtek.com>, Shaofu <shaofu@realtek.com>,
	Steven Ting <steventing@realtek.com>
Subject: [PATCH] rtlwifi: fix simple_open.cocci warnings
Date: Sat, 1 Jul 2017 11:59:13 +0800	[thread overview]
Message-ID: <20170701035913.GA30871@lkp-wsm-ep2> (raw)
In-Reply-To: <20170628151225.22190-10-Larry.Finger@lwfinger.net>

drivers/net/wireless/realtek/rtlwifi/debug.c:398:11-27: WARNING opportunity for simple_open, see also structure on line 418

 Remove an open coded simple_open() function
 and replace file operations references to the function
 with simple_open() instead.

Generated by: scripts/coccinelle/api/simple_open.cocci

Fixes: 3c78fae9727a ("rtlwifi: use debugfs to debug.")
CC: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 debug.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

--- a/drivers/net/wireless/realtek/rtlwifi/debug.c
+++ b/drivers/net/wireless/realtek/rtlwifi/debug.c
@@ -395,13 +395,6 @@ static ssize_t rtl_debugfs_set_write_reg
 	return count;
 }
 
-static int rtl_debugfs_open(struct inode *inode, struct file *filp)
-{
-	filp->private_data = inode->i_private;
-
-	return 0;
-}
-
 static int rtl_debugfs_close(struct inode *inode, struct file *filp)
 {
 	return 0;
@@ -415,7 +408,7 @@ static struct rtl_debgufs_priv rtl_debug
 static const struct file_operations file_ops_write_reg = {
 	.owner = THIS_MODULE,
 	.write = rtl_debugfs_set_write_reg,
-	.open = rtl_debugfs_open,
+	.open = simple_open,
 	.release = rtl_debugfs_close,
 };
 

  parent reply	other threads:[~2017-07-01  3:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 15:12 [PATCH v3 00/10] Set 3 of changes related to updates of btcoexist Larry Finger
2017-06-28 15:12 ` [PATCH v3 01/10] rtlwifi: Fill in_4way field by driver Larry Finger
2017-06-28 15:12 ` [PATCH v3 02/10] rtlwifi: Add BT_MP_INFO to c2h handler Larry Finger
2017-06-28 15:12 ` [PATCH v3 03/10] rtlwifi: Add board type for 8723be and 8192ee Larry Finger
2017-06-28 15:12 ` [PATCH v3 04/10] rtlwifi: add amplifier type for 8812ae Larry Finger
2017-06-28 15:12 ` [PATCH v3 05/10] rtlwifi: Update 8723be new phy parameters and its parser Larry Finger
2017-06-28 15:12 ` [PATCH v3 06/10] rtlwifi: Rename rtl_desc92_rate to rtl_desc_rate Larry Finger
2017-06-28 15:12 ` [PATCH v3 07/10] rtlwifi: Uses addr1 instead DA to determine broadcast and multicast addr Larry Finger
2017-06-28 15:12 ` [PATCH v3 08/10] rtlwifi: move IS_HARDWARE_TYPE_xxx checker to wifi.h Larry Finger
2017-06-28 15:12 ` [PATCH v3 09/10] rtlwifi: use debugfs to debug Larry Finger
2017-07-01  3:59   ` kbuild test robot
2017-07-01  3:59   ` kbuild test robot [this message]
2017-06-28 15:12 ` [PATCH v3 10/10] rtlwifi: btcoex: Use seq_file to dump btcoex status Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170701035913.GA30871@lkp-wsm-ep2 \
    --to=lkp@intel.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=birming@realtek.com \
    --cc=kbuild-all@01.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=shaofu@realtek.com \
    --cc=steventing@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox