Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: prameela.j04cs@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] rsi: immediate wakeup bit and priority for TX command packets
Date: Tue, 1 Aug 2017 14:04:49 +0300	[thread overview]
Message-ID: <20170801110449.5pddqqml32qqlvrn@mwanda> (raw)

Hello Prameela Rani Garnepudi,

The patch 9a629fafe7d8: "rsi: immediate wakeup bit and priority for
TX command packets" from Jul 10, 2017, leads to the following static
checker warning:

	drivers/net/wireless/rsi/rsi_91x_mgmt.c:277 rsi_send_internal_mgmt_frame()
	error: potentially dereferencing uninitialized 'desc'.

drivers/net/wireless/rsi/rsi_91x_mgmt.c
   267  static int rsi_send_internal_mgmt_frame(struct rsi_common *common,
   268                                          struct sk_buff *skb)
   269  {
   270          struct skb_info *tx_params;
   271          struct rsi_cmd_desc *desc;
                                     ^^^^
   272  
   273          if (skb == NULL) {
   274                  rsi_dbg(ERR_ZONE, "%s: Unable to allocate skb\n", __func__);
   275                  return -ENOMEM;
   276          }
   277          desc->desc_dword0.len_qno |= cpu_to_le16(DESC_IMMEDIATE_WAKEUP);
                ^^^^^^

   278          skb->priority = MGMT_SOFT_Q;
   279          tx_params = (struct skb_info *)&IEEE80211_SKB_CB(skb)->driver_data;
   280          tx_params->flags |= INTERNAL_MGMT_PKT;
   281          skb_queue_tail(&common->tx_queue[MGMT_SOFT_Q], skb);
   282          rsi_set_event(&common->tx_thread.event);
   283          return 0;
   284  }

regards,
dan carpenter

             reply	other threads:[~2017-08-01 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 11:04 Dan Carpenter [this message]
2017-08-02  5:57 ` [bug report] rsi: immediate wakeup bit and priority for TX command packets Prameela Rani Garnepudi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801110449.5pddqqml32qqlvrn@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prameela.j04cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox