From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [PATCH v2 09/12] qtnfmac: implement scan timeout
Date: Fri, 4 Aug 2017 23:53:57 +0300 [thread overview]
Message-ID: <20170804205356.4qyfj4wnlnrnvx5d@bars> (raw)
In-Reply-To: <87r2wtugco.fsf@purkki.adurom.net>
> > + if (timer_pending(&mac->scan_timeout))
> > + del_timer_sync(&mac->scan_timeout);
>
> What if the device is removed while the timer is pending, is that
> handled?
Good point. I took another look at this kind of corner cases. Timer is not disabled
explicitely. But ongoing scan request is explicitely aborted in relevant
cfg80211 ops, e.g. on virtual interface change or removal. Though it looks like
some of AP usecases are not handled: e.g. when AP is stopped while scan is
in progress. I will queue the fix into the next cleanup/bugfix patch series
if it is needed to abort scan in such a case.
Thanks,
Sergey
next prev parent reply other threads:[~2017-08-04 20:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 23:06 [PATCH v2] qtnfmac: add more features to driver Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 01/12] qtnfmac: updates for regulatory support Sergey Matyukevich
2017-08-03 10:00 ` [v2,01/12] " Kalle Valo
2017-07-27 23:06 ` [PATCH v2 02/12] qtnfmac: regulatory configuration for self-managed setup Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 03/12] qtnfmac: add missing bus lock Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 04/12] qtnfmac: implement cfg80211 dump_survey handler Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 05/12] qtnfmac: implement reporting current channel Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 06/12] qtnfmac: fix station leave reason endianness Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 07/12] qtnfmac: move current channel info from vif to mac Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 08/12] qtnfmac: implement cfg80211 channel_switch handler Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 09/12] qtnfmac: implement scan timeout Sergey Matyukevich
2017-08-03 9:53 ` Kalle Valo
2017-08-04 20:53 ` Sergey Matyukevich [this message]
2017-08-07 12:43 ` Kalle Valo
2017-07-27 23:06 ` [PATCH v2 10/12] qtnfmac: fix handling of iftype mask reported by firmware Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 11/12] qtnfmac: remove function qtnf_cmd_skb_put_action Sergey Matyukevich
2017-07-27 23:06 ` [PATCH v2 12/12] qtnfmac: prepare for AP_VLAN interface type support Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804205356.4qyfj4wnlnrnvx5d@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox