From: Tony Lindgren <tony@atomide.com>
To: "Reizer, Eyal" <eyalr@ti.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sebastian.reichel@collabora.co.uk"
<sebastian.reichel@collabora.co.uk>,
Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [v6] wlcore: add missing nvs file name info for wilink8
Date: Wed, 9 Aug 2017 14:16:20 -0700 [thread overview]
Message-ID: <20170809211620.GF3934@atomide.com> (raw)
In-Reply-To: <ngx9scofrw0qb2vkesion8v9.1502300336052@email.android.com>
* Reizer, Eyal <eyalr@ti.com> [170809 10:40]:
> Hi Tony,
>
> Sorry for top posting (mobile...)
> I have verified with system design and the data sheet that every wilink 6/7 chip has a mac address in fuse so probably the board you have (pretty old, right?) has this mac address in fuse. Maybe it was from very early batches? Anyway I see no reason to change it.
> Anyway the calibrator can be used to store a different one into the nvs file that will overide it.
Well clearly at least this one does not have any valid hardware
mac address, the hardware mac address is broken with all zeroes.
It seems that you can easily add a check for empty mac address, no?
And you already showed a version that falls back to a random mac
address.
The fact that is old does not change a thing, we still need to
support it no matter what the data sheet and your system design
says. A fix that breaks other things is not really a fix :)
> I have verified using a couple of com6 modules with an am335x-evm and they had mac addresses read ok.
Sounds like there are multiple variants of the wl12xx
available then.
Regards,
Tony
next prev parent reply other threads:[~2017-08-09 21:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1502264840-10569-1-git-send-email-eyalr@ti.com>
2017-08-09 7:53 ` [v6] wlcore: add missing nvs file name info for wilink8 Reizer, Eyal
2017-08-09 17:26 ` Tony Lindgren
2017-08-09 17:28 ` Tony Lindgren
[not found] ` <ngx9scofrw0qb2vkesion8v9.1502300336052@email.android.com>
2017-08-09 21:16 ` Tony Lindgren [this message]
2017-08-10 6:35 ` Reizer, Eyal
2017-08-10 7:46 ` Kalle Valo
2017-08-10 7:59 ` Reizer, Eyal
2017-08-10 7:52 ` Julian Calaby
2017-08-10 7:56 ` Reizer, Eyal
2017-08-10 14:23 ` Reizer, Eyal
2017-08-10 17:26 ` Tony Lindgren
2017-08-13 13:07 ` Reizer, Eyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809211620.GF3934@atomide.com \
--to=tony@atomide.com \
--cc=eyalr@ti.com \
--cc=julian.calaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).