From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43166 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdH3Qtj (ORCPT ); Wed, 30 Aug 2017 12:49:39 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [2/2] rsi: update some comments From: Kalle Valo In-Reply-To: <20170825084037.gxgsieknkb5hxdfs@mwanda> References: <20170825084037.gxgsieknkb5hxdfs@mwanda> To: Dan Carpenter Cc: Prameela Rani Garnepudi , Amitkumar Karwar , Karun Eagalapati , Johannes Berg , Andrew Zaborowski , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Message-Id: <20170830164938.CBEEF60209@smtp.codeaurora.org> (sfid-20170830_184943_135055_FAC18E41) Date: Wed, 30 Aug 2017 16:49:38 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter wrote: > These functions don't return -1 on failure. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c > index 25331aa16e8e..e78e87e99804 100644 > --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c > +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c > @@ -754,7 +754,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw, > * @vif: Pointer to the ieee80211_vif structure. > * @key: Pointer to the ieee80211_key_conf structure. > * > - * Return: status: 0 on success, -1 on failure. > + * Return: status: 0 on success, negative error codes on failure. > */ > static int rsi_hal_key_config(struct ieee80211_hw *hw, > struct ieee80211_vif *vif, > @@ -1194,7 +1194,7 @@ static void rsi_set_min_rate(struct ieee80211_hw *hw, > * @vif: Pointer to the ieee80211_vif structure. > * @sta: Pointer to the ieee80211_sta structure. > * > - * Return: 0 on success, -1 on failure. > + * Return: 0 on success, negative error codes on failure. > */ > static int rsi_mac80211_sta_add(struct ieee80211_hw *hw, > struct ieee80211_vif *vif, > @@ -1306,7 +1306,7 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw, > * @vif: Pointer to the ieee80211_vif structure. > * @sta: Pointer to the ieee80211_sta structure. > * > - * Return: 0 on success, -1 on failure. > + * Return: 0 on success, negative error codes on failure. > */ > static int rsi_mac80211_sta_remove(struct ieee80211_hw *hw, > struct ieee80211_vif *vif, > @@ -1426,7 +1426,7 @@ static int rsi_mac80211_set_antenna(struct ieee80211_hw *hw, > * @tx_ant: Bitmap for tx antenna > * @rx_ant: Bitmap for rx antenna > * > - * Return: 0 on success, -1 on failure. > + * Return: 0 on success, negative error codes on failure. > */ > static int rsi_mac80211_get_antenna(struct ieee80211_hw *hw, > u32 *tx_ant, u32 *rx_ant) > @@ -1533,7 +1533,7 @@ static struct ieee80211_ops mac80211_ops = { > * rsi_mac80211_attach() - This function is used to initialize Mac80211 stack. > * @common: Pointer to the driver private structure. > * > - * Return: 0 on success, -1 on failure. > + * Return: 0 on success, negative error codes on failure. > */ > int rsi_mac80211_attach(struct rsi_common *common) > { 2 patches applied to wireless-drivers-next.git, thanks. fc4386729491 rsi: update some comments 0270639e899e rsi: missing unlocks on error paths -- https://patchwork.kernel.org/patch/9921425/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches