RT2870 failure in kernel 4.12.8

RT2870 failure in kernel 4.12.8

[Larry Finger]

Stanislaw and Helmut,

In a bug report at https://bugzilla.suse.com/show_bug.cgi?id=1055826, the OP 
reports that his RT3572 fails to work after an upgrade from the openSUSE 
Tumbleweed kernel 4.12.7 to 4.12.8. I checked the kernel configuration and did 
not see any problems.

Are you aware of anyone reporting problems with rt2800usb in 4.12.8 kernels?

Thanks,

Larry

Re: RT2870 failure in kernel 4.12.8

[Stanislaw Gruszka]

On Wed, Aug 30, 2017 at 12:03:06PM -0500, Larry Finger wrote:
> Stanislaw and Helmut,
> 
> In a bug report at https://bugzilla.suse.com/show_bug.cgi?id=1055826, the OP
> reports that his RT3572 fails to work after an upgrade from the openSUSE
> Tumbleweed kernel 4.12.7 to 4.12.8. I checked the kernel configuration and
> did not see any problems.
> 
> Are you aware of anyone reporting problems with rt2800usb in 4.12.8 kernels?

I think it is the issue addressed by this 4.12 patch:
https://marc.info/?l=linux-wireless&m=150366111408179&w=2 

Patch for 4.13+ kernels is here:
https://marc.info/?l=linux-wireless&m=150367345912061&w=2

Thanks
Stanislaw

Re: RT2870 failure in kernel 4.12.8

[Kalle Valo]

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Wed, Aug 30, 2017 at 12:03:06PM -0500, Larry Finger wrote:
>> Stanislaw and Helmut,
>> 
>> In a bug report at https://bugzilla.suse.com/show_bug.cgi?id=1055826, the OP
>> reports that his RT3572 fails to work after an upgrade from the openSUSE
>> Tumbleweed kernel 4.12.7 to 4.12.8. I checked the kernel configuration and
>> did not see any problems.
>> 
>> Are you aware of anyone reporting problems with rt2800usb in 4.12.8 kernels?
>
> I think it is the issue addressed by this 4.12 patch:
> https://marc.info/?l=linux-wireless&m=150366111408179&w=2 
>
> Patch for 4.13+ kernels is here:
> https://marc.info/?l=linux-wireless&m=150367345912061&w=2

And the commit is here:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=83ec489193894e52bd395eec470f4f7c4286d4a5

-- 
Kalle Valo

Re: RT2870 failure in kernel 4.12.8

[Larry Finger]

On 08/31/2017 02:55 AM, Stanislaw Gruszka wrote:
> I think it is the issue addressed by this 4.12 patch:
> https://marc.info/?l=linux-wireless&m=150366111408179&w=2
> 
> Patch for 4.13+ kernels is here:
> https://marc.info/?l=linux-wireless&m=150367345912061&w=2

A potential problem with this solution is that commit 41977e86c984 ("rt2x00: add 
support for MT7620") has been in the kernel since 4.12.0, but the openSUSE 
problem was reported not to occur until 4.12.8. I have asked that this patch be 
applied to the openSUSE source and a special test kernel be generated for our 
OP. I will let you know what develops. I do not have the necessary hardware to 
do the test in house.

Should the patch to wireless-drivers be annotated with a Stable reference so 
that it is added to 4.12 and 4.13?

Thanks,

Larry

Re: RT2870 failure in kernel 4.12.8

[Stanislaw Gruszka]

On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
> Should the patch to wireless-drivers be annotated with a Stable reference so
> that it is added to 4.12 and 4.13?

According to Documentation/networking/netdev-FAQ.txt networking patches
should not be marked cc:stable, instead a decent commit log should
be written describing a bugfix. Which I believe it is done for
this patch.

Thanks
Stanislaw 

Re: RT2870 failure in kernel 4.12.8

[Kalle Valo]

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
>> Should the patch to wireless-drivers be annotated with a Stable reference so
>> that it is added to 4.12 and 4.13?
>
> According to Documentation/networking/netdev-FAQ.txt networking patches
> should not be marked cc:stable, instead a decent commit log should
> be written describing a bugfix. Which I believe it is done for
> this patch.

But that's for net and net-next trees, not for wireless trees. With
wireless patches we use "Cc: stable@..." references.

-- 
Kalle Valo

Re: RT2870 failure in kernel 4.12.8

[Larry Finger]

On 09/01/2017 09:31 AM, Kalle Valo wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> writes:
> 
>> On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
>>> Should the patch to wireless-drivers be annotated with a Stable reference so
>>> that it is added to 4.12 and 4.13?
>>
>> According to Documentation/networking/netdev-FAQ.txt networking patches
>> should not be marked cc:stable, instead a decent commit log should
>> be written describing a bugfix. Which I believe it is done for
>> this patch.
> 
> But that's for net and net-next trees, not for wireless trees. With
> wireless patches we use "Cc: stable@..." references.

I see that this patch was just pushed for 4.14. I hope it got the Stable 
annotation at that time.

Larry

Re: RT2870 failure in kernel 4.12.8

[Kalle Valo]

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 09/01/2017 09:31 AM, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>>
>>> On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
>>>> Should the patch to wireless-drivers be annotated with a Stable reference so
>>>> that it is added to 4.12 and 4.13?
>>>
>>> According to Documentation/networking/netdev-FAQ.txt networking patches
>>> should not be marked cc:stable, instead a decent commit log should
>>> be written describing a bugfix. Which I believe it is done for
>>> this patch.
>>
>> But that's for net and net-next trees, not for wireless trees. With
>> wireless patches we use "Cc: stable@..." references.
>
> I see that this patch was just pushed for 4.14. I hope it got the
> Stable annotation at that time.

Justo to be sure, my understanding is that we are here talking about
this commit:

rt2800: fix TX_PIN_CFG setting for non MT7620 chips

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=83ec489193894e52bd395eec470f4f7c4286d4a5

I applied that already last Wednesday and that was without "Cc: stable".
So now someone should follow Option 2, wait the commit to hit Linus'
tree (I expect it to happen some time this week) and then send a note to
the stable team:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-2

Or if the commit doesn't apply cleanly to v4.13 then Option 3 is of
course the better approach.

-- 
Kalle Valo

Re: RT2870 failure in kernel 4.12.8

[Stanislaw Gruszka]

On Fri, Sep 01, 2017 at 05:31:57PM +0300, Kalle Valo wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> writes:
> 
> > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
> >> Should the patch to wireless-drivers be annotated with a Stable reference so
> >> that it is added to 4.12 and 4.13?
> >
> > According to Documentation/networking/netdev-FAQ.txt networking patches
> > should not be marked cc:stable, instead a decent commit log should
> > be written describing a bugfix. Which I believe it is done for
> > this patch.
> 
> But that's for net and net-next trees, not for wireless trees. With
> wireless patches we use "Cc: stable@..." references.

Oh, ok. I was confused by below part of
Documentation/process/stable-kernel-rules.rst 
(because wireless drivers are located in drivers/net/)

 - If the patch covers files in net/ or drivers/net please follow netdev stable
   submission guidelines as described in
   Documentation/networking/netdev-FAQ.txt

Thanks
Stanislaw

stable-kernel-rules: wireless and netdev-FAQ

[Kalle Valo]

(adding netdev and lkml)

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Fri, Sep 01, 2017 at 05:31:57PM +0300, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>> 
>> > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote:
>> >> Should the patch to wireless-drivers be annotated with a Stable reference so
>> >> that it is added to 4.12 and 4.13?
>> >
>> > According to Documentation/networking/netdev-FAQ.txt networking patches
>> > should not be marked cc:stable, instead a decent commit log should
>> > be written describing a bugfix. Which I believe it is done for
>> > this patch.
>> 
>> But that's for net and net-next trees, not for wireless trees. With
>> wireless patches we use "Cc: stable@..." references.
>
> Oh, ok. I was confused by below part of
> Documentation/process/stable-kernel-rules.rst 
> (because wireless drivers are located in drivers/net/)
>
>  - If the patch covers files in net/ or drivers/net please follow netdev stable
>    submission guidelines as described in
>    Documentation/networking/netdev-FAQ.txt

Yeah, that's confusing and should be clarified that wireless follows
traditional stable process. IIRC bluetooth does the same so it's not
just wireless.

Any volunteers to fix it? :)

-- 
Kalle Valo

Re: RT2870 failure in kernel 4.12.8

[Larry Finger]

On 08/31/2017 02:55 AM, Stanislaw Gruszka wrote:
> On Wed, Aug 30, 2017 at 12:03:06PM -0500, Larry Finger wrote:
>> Stanislaw and Helmut,
>>
>> In a bug report at https://bugzilla.suse.com/show_bug.cgi?id=1055826, the OP
>> reports that his RT3572 fails to work after an upgrade from the openSUSE
>> Tumbleweed kernel 4.12.7 to 4.12.8. I checked the kernel configuration and
>> did not see any problems.
>>
>> Are you aware of anyone reporting problems with rt2800usb in 4.12.8 kernels?
> 
> I think it is the issue addressed by this 4.12 patch:
> https://marc.info/?l=linux-wireless&m=150366111408179&w=2
> 
> Patch for 4.13+ kernels is here:
> https://marc.info/?l=linux-wireless&m=150367345912061&w=2

That patch did fix the problem. Thanks for the help.

Larry