* [PATCH v2] brcmfmac: Log chip id and revision
@ 2017-08-30 13:54 Hans de Goede
2017-08-30 18:49 ` Arend van Spriel
2017-08-31 12:59 ` [v2] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2017-08-30 13:54 UTC (permalink / raw)
To: Arend van Spriel, Kalle Valo
Cc: Hans de Goede, linux-wireless, brcm80211-dev-list.pdl
For debugging some problems, it is useful to know the chip revision
add a brcmf_info message logging this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-Put the brcmf_info in brcmf_fw_map_chip_to_name() so that it works for
e.g. pcie devices too
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
index d231042f19d6..091b52979e03 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c
@@ -601,6 +601,9 @@ int brcmf_fw_map_chip_to_name(u32 chip, u32 chiprev,
if ((nvram_name) && (mapping_table[i].nvram))
strlcat(nvram_name, mapping_table[i].nvram, BRCMF_FW_NAME_LEN);
+ brcmf_info("using %s for chip %#08x(%d) rev %#08x\n",
+ fw_name, chip, chip, chiprev);
+
return 0;
}
--
2.13.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] brcmfmac: Log chip id and revision
2017-08-30 13:54 [PATCH v2] brcmfmac: Log chip id and revision Hans de Goede
@ 2017-08-30 18:49 ` Arend van Spriel
2017-08-31 12:59 ` [v2] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2017-08-30 18:49 UTC (permalink / raw)
To: Hans de Goede, Kalle Valo; +Cc: linux-wireless, brcm80211-dev-list.pdl
On 30-08-17 15:54, Hans de Goede wrote:
> For debugging some problems, it is useful to know the chip revision
> add a brcmf_info message logging this.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Put the brcmf_info in brcmf_fw_map_chip_to_name() so that it works for
> e.g. pcie devices too
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +++
> 1 file changed, 3 insertions(+)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] brcmfmac: Log chip id and revision
2017-08-30 13:54 [PATCH v2] brcmfmac: Log chip id and revision Hans de Goede
2017-08-30 18:49 ` Arend van Spriel
@ 2017-08-31 12:59 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-08-31 12:59 UTC (permalink / raw)
To: Hans de Goede
Cc: Arend van Spriel, Hans de Goede, linux-wireless,
brcm80211-dev-list.pdl
Hans de Goede <hdegoede@redhat.com> wrote:
> For debugging some problems, it is useful to know the chip revision
> add a brcmf_info message logging this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
f38966a7ace8 brcmfmac: Log chip id and revision
--
https://patchwork.kernel.org/patch/9929651/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-31 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30 13:54 [PATCH v2] brcmfmac: Log chip id and revision Hans de Goede
2017-08-30 18:49 ` Arend van Spriel
2017-08-31 12:59 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).