From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, toke@toke.dk
Subject: Re: [PATCH] mac80211: make STA_SLOW_THRESHOLD local
Date: Tue, 26 Sep 2017 13:23:59 +0200 [thread overview]
Message-ID: <20170926112359.GA5744@redhat.com> (raw)
In-Reply-To: <1506421094.22427.8.camel@sipsolutions.net>
On Tue, Sep 26, 2017 at 12:18:14PM +0200, Johannes Berg wrote:
> On Tue, 2017-09-26 at 11:59 +0200, Stanislaw Gruszka wrote:
> > STA_SLOW_THRESHOLD is used only in one function, so don't need to be
> > global define.
> >
> > Patch also fixes problem of htmldocs build I encountered:
> >
> > Error(.//net/mac80211/sta_info.h:416): cannot understand prototype:
> > 'STA_SLOW_THRESHOLD 6000????'
>
> Why not just change /** to /*? I think it's better to keep it there
> even if it's not used, it's a more public thing than the code?
I thought local references are preferred over global. Fixing only
comment is fine for me, I'll post v2.
Stanislaw
prev parent reply other threads:[~2017-09-26 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 9:59 [PATCH] mac80211: make STA_SLOW_THRESHOLD local Stanislaw Gruszka
2017-09-26 10:18 ` Johannes Berg
2017-09-26 11:23 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926112359.GA5744@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).