* [PATCH] rtlwifi: rtl8821ae: Fix connection lost problem
@ 2017-09-20 21:15 Larry Finger
2017-09-25 8:06 ` Kalle Valo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Larry Finger @ 2017-09-20 21:15 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger, Stable, Ping-Ke Shih
In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read
of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi
this change results in reduced stability for the wireless connection.
This regression was located using bisection.
Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues")
Reported-and-tested-by: James Cameron <quozl@laptop.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> # 4.11+
Cc: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
index 3571ce4bd276..ac2ce86de506 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
@@ -1122,7 +1122,7 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr)
}
if (0 == tmp) {
read_addr = REG_DBI_RDATA + addr % 4;
- ret = rtl_read_byte(rtlpriv, read_addr);
+ ret = rtl_read_word(rtlpriv, read_addr);
}
return ret;
}
--
2.12.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: rtlwifi: rtl8821ae: Fix connection lost problem
2017-09-20 21:15 [PATCH] rtlwifi: rtl8821ae: Fix connection lost problem Larry Finger
@ 2017-09-25 8:06 ` Kalle Valo
[not found] ` <20170925080623.39A116099A@smtp.codeaurora.org>
2017-10-02 13:04 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-09-25 8:06 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Stable, Ping-Ke Shih
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read
> of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi
> this change results in reduced stability for the wireless connection.
> This regression was located using bisection.
>
> Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues")
> Reported-and-tested-by: James Cameron <quozl@laptop.org>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org> # 4.11+
> Cc: Ping-Ke Shih <pkshih@realtek.com>
Should I queue this for 4.14?
(The first commit was v4.11-rc1.)
--
https://patchwork.kernel.org/patch/9962615/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <20170925080623.39A116099A@smtp.codeaurora.org>]
* Re: rtlwifi: rtl8821ae: Fix connection lost problem
[not found] ` <20170925080623.39A116099A@smtp.codeaurora.org>
@ 2017-09-25 15:39 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2017-09-25 15:39 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Stable, Ping-Ke Shih
On 09/25/2017 03:06 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read
>> of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi
>> this change results in reduced stability for the wireless connection.
>> This regression was located using bisection.
>>
>> Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues")
>> Reported-and-tested-by: James Cameron <quozl@laptop.org>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org> # 4.11+
>> Cc: Ping-Ke Shih <pkshih@realtek.com>
>
> Should I queue this for 4.14?
>
> (The first commit was v4.11-rc1.)
Yes, please do.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: rtlwifi: rtl8821ae: Fix connection lost problem
2017-09-20 21:15 [PATCH] rtlwifi: rtl8821ae: Fix connection lost problem Larry Finger
2017-09-25 8:06 ` Kalle Valo
[not found] ` <20170925080623.39A116099A@smtp.codeaurora.org>
@ 2017-10-02 13:04 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-10-02 13:04 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Stable, Ping-Ke Shih
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read
> of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi
> this change results in reduced stability for the wireless connection.
> This regression was located using bisection.
>
> Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues")
> Reported-and-tested-by: James Cameron <quozl@laptop.org>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org> # 4.11+
> Cc: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers.git, thanks.
b8b8b16352cd rtlwifi: rtl8821ae: Fix connection lost problem
--
https://patchwork.kernel.org/patch/9962615/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-02 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 21:15 [PATCH] rtlwifi: rtl8821ae: Fix connection lost problem Larry Finger
2017-09-25 8:06 ` Kalle Valo
[not found] ` <20170925080623.39A116099A@smtp.codeaurora.org>
2017-09-25 15:39 ` Larry Finger
2017-10-02 13:04 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).