From: Stephen Hemminger <stephen@networkplumber.org>
To: Colin King <colin.king@canonical.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"David S . Miller" <davem@davemloft.net>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFC: fdp: make struct nci_ops static
Date: Thu, 5 Oct 2017 08:09:02 -0700 [thread overview]
Message-ID: <20171005080902.30b95db3@xeon-e3> (raw)
In-Reply-To: <20171005094712.28627-1-colin.king@canonical.com>
On Thu, 5 Oct 2017 10:47:12 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure nci_ops is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'nci_ops' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nfc/fdp/fdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c
> index ec50027b0d8b..d5784a47fc13 100644
> --- a/drivers/nfc/fdp/fdp.c
> +++ b/drivers/nfc/fdp/fdp.c
> @@ -726,7 +726,7 @@ static struct nci_driver_ops fdp_prop_ops[] = {
> },
> };
>
> -struct nci_ops nci_ops = {
> +static struct nci_ops nci_ops = {
> .open = fdp_nci_open,
> .close = fdp_nci_close,
> .send = fdp_nci_send,
Why not static const?
Yes this goes deeper. NFC needs to make all nfc ops const.
next prev parent reply other threads:[~2017-10-05 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 9:47 [PATCH] NFC: fdp: make struct nci_ops static Colin King
2017-10-05 15:09 ` Stephen Hemminger [this message]
2017-11-06 0:06 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005080902.30b95db3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).