* [PATCH 2/2] rtlwifi: silence underflow warning
[not found] <20170929075117.cno3vnrebea32upt@mwanda>
@ 2017-09-29 7:52 ` Dan Carpenter
2017-10-10 8:20 ` [2/2] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-09-29 7:52 UTC (permalink / raw)
To: Larry Finger; +Cc: Chaoming Li, Kalle Valo, linux-wireless, kernel-janitors
My static checker complains that we have an upper bound but no lower
bound. I suspect neither are really required but it doesn't hurt to add
a check for negatives.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index c53cbf3d52bd..294a6b43d1bc 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
for (i = 0; i < wow->n_patterns; i++) {
memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
- if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
+ if (patterns[i].pattern_len < 0 ||
+ patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
"Pattern[%d] is too long\n", i);
continue;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2/2] rtlwifi: silence underflow warning
2017-09-29 7:52 ` [PATCH 2/2] rtlwifi: silence underflow warning Dan Carpenter
@ 2017-10-10 8:20 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-10-10 8:20 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Larry Finger, Chaoming Li, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> My static checker complains that we have an upper bound but no lower
> bound. I suspect neither are really required but it doesn't hurt to add
> a check for negatives.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index c53cbf3d52bd..294a6b43d1bc 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
> for (i = 0; i < wow->n_patterns; i++) {
> memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
> memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
> - if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
> + if (patterns[i].pattern_len < 0 ||
> + patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
> RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
> "Pattern[%d] is too long\n", i);
> continue;
Patch applied to wireless-drivers-next.git, thanks.
64e79426c204 rtlwifi: silence underflow warning
--
https://patchwork.kernel.org/patch/9977201/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-10 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170929075117.cno3vnrebea32upt@mwanda>
2017-09-29 7:52 ` [PATCH 2/2] rtlwifi: silence underflow warning Dan Carpenter
2017-10-10 8:20 ` [2/2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).