From: Brian Norris <briannorris@chromium.org>
To: Ganapathi Bhat <gbhat@marvell.com>
Cc: linux-wireless@vger.kernel.org, Cathy Luo <cluo@marvell.com>,
Xinming Hu <huxm@marvell.com>, Zhiyuan Yang <yangzy@marvell.com>,
James Cao <jcao@marvell.com>,
Mangesh Malusare <mmangesh@marvell.com>,
Karthik Ananthapadmanabha <karthida@marvell.com>
Subject: Re: [PATCH] mwifiex: Random MAC address during scanning
Date: Wed, 11 Oct 2017 12:41:50 -0700 [thread overview]
Message-ID: <20171011194148.GA84547@google.com> (raw)
In-Reply-To: <1506682390-27716-1-git-send-email-gbhat@marvell.com>
On Fri, Sep 29, 2017 at 04:23:10PM +0530, Ganapathi Bhat wrote:
> From: Karthik Ananthapadmanabha <karthida@marvell.com>
>
> Driver will advertise RANDOM_MAC support only if the device
> supports this feature.
>
> Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
I'd just like to point out that this is a very bad commit subject:
"[PATCH] mwifiex: Random MAC address during scanning"
It's borderline wrong, really. "Random MAC address during scanning" is
already supported. This patch is just adding a feature-flag check for
it, since some firmwares in the wild don't support it. A more accurate
description would be something like:
"[PATCH] mwifiex: Add feature flag support for MAC randomization"
The patch is already applied, so I'd only worry about it for future
submissions (no need to resend).
Brian
next prev parent reply other threads:[~2017-10-11 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 10:53 [PATCH] mwifiex: Random MAC address during scanning Ganapathi Bhat
2017-10-10 8:21 ` Kalle Valo
2017-10-11 19:41 ` Brian Norris [this message]
2017-10-12 5:27 ` [EXT] Re: [PATCH] " Ganapathi Bhat
2017-10-12 5:53 ` Ganapathi Bhat
2017-10-12 7:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011194148.GA84547@google.com \
--to=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=karthida@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmangesh@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).