From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: [PATCH 04/17] iwlwifi: mvm: rs: remove the ANT C from the toogle antenna logic
Date: Sun, 29 Oct 2017 14:28:03 +0200 [thread overview]
Message-ID: <20171029122816.8802-5-luca@coelho.fi> (raw)
In-Reply-To: <20171029122816.8802-1-luca@coelho.fi>
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
We don't plan to have products with 3 antennas in the near
future. All the rest of the code follows the same
assumption as well.
Remove the support for antenna C from rs_toggle_ant.
When trying to toggle from ANT_B, this avoids to go through
ANT_C, discover that it doesn't exist and continue to ANT_A.
In MIMO, this avoids to do ANT_AB -> ANT_BC -> ANT_AC and
back to ANT_AB.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
index 0fe723ca844e..c69515ed72df 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
@@ -67,12 +67,8 @@ static u8 rs_ht_to_legacy[] = {
static const u8 ant_toggle_lookup[] = {
[ANT_NONE] = ANT_NONE,
[ANT_A] = ANT_B,
- [ANT_B] = ANT_C,
- [ANT_AB] = ANT_BC,
- [ANT_C] = ANT_A,
- [ANT_AC] = ANT_AB,
- [ANT_BC] = ANT_AC,
- [ANT_ABC] = ANT_ABC,
+ [ANT_B] = ANT_A,
+ [ANT_AB] = ANT_AB,
};
#define IWL_DECLARE_RATE_INFO(r, s, rp, rn) \
@@ -975,7 +971,7 @@ static int rs_toggle_antenna(u32 valid_ant, struct rs_rate *rate)
{
u8 new_ant_type;
- if (!rate->ant || rate->ant > ANT_ABC)
+ if (!rate->ant || WARN_ON_ONCE(rate->ant & ANT_C))
return 0;
if (!rs_is_valid_ant(valid_ant, rate->ant))
--
2.14.2
next prev parent reply other threads:[~2017-10-29 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 12:27 [PATCH 00/17] iwlwifi: updates intended for v4.15 2017-10-29 Luca Coelho
2017-10-29 12:28 ` [PATCH 01/17] iwlwifi: mvm: use RS macro instead of duplicating the code Luca Coelho
2017-10-29 12:28 ` [PATCH 02/17] iwlwifi: mvm: cleanup references to aggregation count limit Luca Coelho
2017-10-29 12:28 ` [PATCH 03/17] iwlwifi: mvm: reset seq num after restart Luca Coelho
2017-10-29 12:28 ` Luca Coelho [this message]
2017-10-29 12:28 ` [PATCH 05/17] iwlwifi: mvm: improve latency when there is a reorder timeout Luca Coelho
2017-10-29 12:28 ` [PATCH 06/17] iwlwifi: remove dead code for internal devices only Luca Coelho
2017-10-29 12:28 ` [PATCH 07/17] iwlwifi: remove host assisted paging Luca Coelho
2017-10-29 12:28 ` [PATCH 08/17] iwlwifi: Add more call-sites for pcie reg dumper Luca Coelho
2017-10-29 12:28 ` [PATCH 09/17] iwlwifi: fix multi queue notification for a000 devices Luca Coelho
2017-10-29 12:28 ` [PATCH 10/17] iwlwifi: mvm: refactor iwl_mvm_flush_no_vif Luca Coelho
2017-10-29 12:28 ` [PATCH 11/17] iwlwifi: mvm: add missing implementation of flush for a000 devices Luca Coelho
2017-10-29 12:28 ` [PATCH 12/17] iwlwifi: mvm: hold mutex when flushing in iwl_mvm_flush_no_vif() Luca Coelho
2017-10-29 12:28 ` [PATCH 13/17] iwlwifi: mvm: Convert timers to use timer_setup() Luca Coelho
2017-11-06 19:45 ` Kees Cook
2017-11-06 19:48 ` Luca Coelho
2017-11-06 20:40 ` Kees Cook
2017-10-29 12:28 ` [PATCH 14/17] iwlwifi: drop RX frames during hardware restart Luca Coelho
2017-10-29 12:28 ` [PATCH 15/17] iwlwifi: add new cards for 8260 series Luca Coelho
2017-10-29 12:28 ` [PATCH 16/17] iwlwifi: add new cards for 8265 series Luca Coelho
2017-10-29 12:28 ` [PATCH 17/17] iwlwifi: add new cards for a000 series Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171029122816.8802-5-luca@coelho.fi \
--to=luca@coelho.fi \
--cc=emmanuel.grumbach@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox