* [PATCH] libertas: don't write wdev->ssid/_len
@ 2017-10-17 19:37 Johannes Berg
2017-10-30 10:48 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2017-10-17 19:37 UTC (permalink / raw)
To: linux-wireless; +Cc: Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
When joining an IBSS network, wdev->ssid/_len will already be
set, so there's no need to write them. In any case, they are
internal cfg80211 values, and have very little user-visible
impact.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/net/wireless/marvell/libertas/cfg.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c
index 71ba2c8d09b5..bb76707881cd 100644
--- a/drivers/net/wireless/marvell/libertas/cfg.c
+++ b/drivers/net/wireless/marvell/libertas/cfg.c
@@ -1698,9 +1698,6 @@ static void lbs_join_post(struct lbs_private *priv,
0, GFP_KERNEL);
cfg80211_put_bss(priv->wdev->wiphy, bss);
- memcpy(priv->wdev->ssid, params->ssid, params->ssid_len);
- priv->wdev->ssid_len = params->ssid_len;
-
cfg80211_ibss_joined(priv->dev, bssid, params->chandef.chan,
GFP_KERNEL);
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: libertas: don't write wdev->ssid/_len
2017-10-17 19:37 [PATCH] libertas: don't write wdev->ssid/_len Johannes Berg
@ 2017-10-30 10:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2017-10-30 10:48 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Johannes Berg
Johannes Berg <johannes@sipsolutions.net> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When joining an IBSS network, wdev->ssid/_len will already be
> set, so there's no need to write them. In any case, they are
> internal cfg80211 values, and have very little user-visible
> impact.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Patch applied to wireless-drivers-next.git, thanks.
39a9cd5a0e4e libertas: don't write wdev->ssid/_len
--
https://patchwork.kernel.org/patch/10012783/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 19:37 [PATCH] libertas: don't write wdev->ssid/_len Johannes Berg
2017-10-30 10:48 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).