From: Brian Norris <briannorris@chromium.org>
To: Ganapathi Bhat <gbhat@marvell.com>
Cc: "linux-firmware@kernel.org" <linux-firmware@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
James Cao <jcao@marvell.com>, Cathy Luo <cluo@marvell.com>,
Mangesh Malusare <mmangesh@marvell.com>,
Xinming Hu <huxm@marvell.com>, Zhiyuan Yang <yangzy@marvell.com>,
Karthik Doddayennegere Ananthapadmanabha <karthida@marvell.com>
Subject: Re: [EXT] Re: pull-request mwifiex-firmware 2017-10-30
Date: Mon, 30 Oct 2017 11:50:43 -0700 [thread overview]
Message-ID: <20171030185043.GA100626@google.com> (raw)
In-Reply-To: <fb8d8eece601415c83167c500d80ff2f@SC-EXCH02.marvell.com>
On Mon, Oct 30, 2017 at 06:47:58PM +0000, Ganapathi Bhat wrote:
> > ----------------------------------------------------------------------
> > On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:
> > > --- a/WHENCE
> > > +++ b/WHENCE
> > > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
> > > Version: 16.68.1.p70
> > >
> > > File: mrvl/pcieusb8997_combo_v4.bin
> > > -Version: 16.68.1.p133
> > > +Version: 16.68.1.p40
> >
> > This says .p40, whereas the commit message (and the version tag within the
> > firmware) says p140. I think you're missing a "1".
> I did miss this. Will it make sense to trigger another pull request with just the version change?
Sure, why not? Email is cheap, and so is git. Either rewrite the commit
or add another on top to fix it...
next prev parent reply other threads:[~2017-10-30 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 14:13 pull-request mwifiex-firmware 2017-10-30 Ganapathi Bhat
2017-10-30 17:03 ` Brian Norris
2017-10-30 18:47 ` [EXT] " Ganapathi Bhat
2017-10-30 18:50 ` Brian Norris [this message]
2017-10-30 19:02 ` Ganapathi Bhat
2017-10-30 19:47 ` Brian Norris
2017-10-31 15:40 ` Ganapathi Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030185043.GA100626@google.com \
--to=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=karthida@marvell.com \
--cc=linux-firmware@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mmangesh@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).