From: Samuel Ortiz <sameo@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Robert Baldyga <r.baldyga@samsung.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
linux-nfc@lists.01.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size
Date: Mon, 6 Nov 2017 01:03:43 +0100 [thread overview]
Message-ID: <20171106000343.GC27831@zurbaran.ger.intel.com> (raw)
In-Reply-To: <20170919142515.23196-1-colin.king@canonical.com>
Hi Colin,
On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only array match on the stack, instead make
> it static const. Makes the object code smaller by over 310 bytes:
>
> Before:
> text data bss dec hex filename
> 8304 1084 128 9516 252c drivers/nfc/s3fwrn5/firmware.o
>
> After:
> text data bss dec hex filename
> 7894 1180 128 9202 23f2 drivers/nfc/s3fwrn5/firmware.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nfc/s3fwrn5/firmware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to nfc-next, thanks.
Cheers,
Samuel.
prev parent reply other threads:[~2017-11-06 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 14:25 [PATCH] nfc: s3fwrn5: make array match static const, reduces object code size Colin King
2017-11-06 0:03 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106000343.GC27831@zurbaran.ger.intel.com \
--to=sameo@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=k.opasiak@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox