From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:38490 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbdKWH2W (ORCPT ); Thu, 23 Nov 2017 02:28:22 -0500 Date: Thu, 23 Nov 2017 15:27:24 +0800 From: kbuild test robot To: Felix Fietkau Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org, kvalo@codeaurora.org Subject: [PATCH] mt76: fix returnvar.cocci warnings Message-ID: <20171123072724.GA16591@lkp-ne02> (sfid-20171123_082829_372012_8F484134) References: <20171120193549.80831-4-nbd@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20171120193549.80831-4-nbd@nbd.name> Sender: linux-wireless-owner@vger.kernel.org List-ID: drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") CC: Felix Fietkau Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! mt76x2_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/wireless/mediatek/mt76/mt76x2_main.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_main.c @@ -83,7 +83,6 @@ mt76x2_add_interface(struct ieee80211_hw struct mt76x2_dev *dev = hw->priv; struct mt76x2_vif *mvif = (struct mt76x2_vif *) vif->drv_priv; unsigned int idx = 0; - int ret = 0; if (vif->addr[0] & BIT(1)) idx = 1 + (((dev->mt76.macaddr[0] ^ vif->addr[0]) >> 2) & 7); @@ -109,7 +108,7 @@ mt76x2_add_interface(struct ieee80211_hw mvif->group_wcid.hw_key_idx = -1; mt76x2_txq_init(dev, vif->txq); - return ret; + return 0; } static void