From: "Peter Große" <pegro@friiks.de>
To: linux-wireless@vger.kernel.org
Subject: Re: Setting TX power on a monitoring interface
Date: Mon, 27 Nov 2017 16:07:22 +0100 [thread overview]
Message-ID: <20171127160722.4969cd23@friiks.de> (raw)
In-Reply-To: <1511782993.5456.6.camel@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Mon, 27 Nov 2017 12:43:13 +0100
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> > What would be the correct way of fixing it? Maybe I can provide a patch.
>
> That's a really good question :-)
>
> I think if the driver has WANT_MONITOR_VIF, then we can pass that
> through and let the driver sort it out.
>
> But if not, we probably just have to reject the configuration?
With passing through you mean calling bss_info_changed on the driver for the
monitor interface?
Are monitor interfaces allowed to exist when WANT_MONITOR_VIF is not set?
I ask, whether I would have to check
sdata->vif.type == NL80211_IFTYPE_MONITOR
_and_ also
ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)
?
Regards
Peter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-11-27 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 16:34 Setting TX power on a monitoring interface Peter Große
2017-11-27 11:43 ` Johannes Berg
2017-11-27 15:07 ` Peter Große [this message]
2017-12-01 14:49 ` Johannes Berg
2017-12-01 17:34 ` Peter Große
2017-12-09 19:53 ` Johannes Berg
2017-12-13 17:29 ` [PATCH] mac80211: Fix setting TX power on monitor interfaces Peter Große
2017-12-19 9:53 ` Johannes Berg
2017-12-19 19:25 ` Peter Große
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127160722.4969cd23@friiks.de \
--to=pegro@friiks.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).