From: Kalle Valo <kvalo@codeaurora.org>
To: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>
Cc: linux-wireless@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>
Subject: Re: [v2] wireless: use ARRAY_SIZE
Date: Fri, 8 Dec 2017 13:20:47 +0000 (UTC) [thread overview]
Message-ID: <20171208132047.0BBC2607F4@smtp.codeaurora.org> (raw)
In-Reply-To: <20171114031941.22105-1-jeremy.lefaure@lse.epita.fr>
Jérémy Lefaure wrote:
> Using the ARRAY_SIZE macro improves the readability of the code. Also,
> it is not always useful to use a variable to store this constant
> calculated at compile time.
>
> Found with Coccinelle with the following semantic patch:
> @r depends on (org || report)@
> type T;
> T[] E;
> position p;
> @@
> (
> (sizeof(E)@p /sizeof(*E))
> |
> (sizeof(E)@p /sizeof(E[...]))
> |
> (sizeof(E)@p /sizeof(T))
> )
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Patch applied to wireless-drivers-next.git, thanks.
53ac79359327 wireless: use ARRAY_SIZE
--
https://patchwork.kernel.org/patch/10057021/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-12-08 13:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure
2017-10-02 13:07 ` Andy Shevchenko
2017-10-03 1:22 ` Jérémy Lefaure
2017-10-03 8:09 ` Andy Shevchenko
2017-10-02 13:46 ` Kalle Valo
2017-10-03 1:23 ` Jérémy Lefaure
2017-11-14 3:19 ` [PATCH v2] wireless: " Jérémy Lefaure
2017-12-08 13:20 ` Kalle Valo [this message]
2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding
2017-10-02 0:52 ` Jérémy Lefaure
2017-10-02 5:35 ` Greg KH
2017-10-02 19:22 ` J. Bruce Fields
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-05 17:57 ` J. Bruce Fields
2017-10-02 16:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208132047.0BBC2607F4@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=jeremy.lefaure@lse.epita.fr \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).