From: "Peter Große" <pegro@friiks.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] ocb: Use common freqchan helper for setting the operating channel
Date: Wed, 13 Dec 2017 13:58:40 +0100 [thread overview]
Message-ID: <20171213125840.1036-1-pegro@friiks.de> (raw)
In-Reply-To: <1512991065.26976.70.camel@sipsolutions.net>
Simplify code by using the helper which has been introduced earlier.
Signed-off-by: Peter Große <pegro@friiks.de>
---
Mh, the patch is against the full tree of iw, not the kernel, so there is no
net/wireless/ path.
But yeah, whitespace got mangled.
Regards
Peter
ocb.c | 50 ++++++++------------------------------------------
1 file changed, 8 insertions(+), 42 deletions(-)
diff --git a/ocb.c b/ocb.c
index bcf0474..dfdaf59 100644
--- a/ocb.c
+++ b/ocb.c
@@ -10,56 +10,22 @@ static int join_ocb(struct nl80211_state *state,
struct nl_msg *msg, int argc, char **argv,
enum id_input id)
{
- unsigned long freq;
- char *end;
- unsigned int i;
- const struct chanmode *chanmode_selected = NULL;
- static const struct chanmode chanmode[] = {
- { .name = "5MHz",
- .width = NL80211_CHAN_WIDTH_5,
- .freq1_diff = 0,
- .chantype = -1 },
- { .name = "10MHz",
- .width = NL80211_CHAN_WIDTH_10,
- .freq1_diff = 0,
- .chantype = -1 },
- };
+ struct chandef chandef;
+ int err, parsed;
if (argc < 2)
return 1;
- /* freq */
- freq = strtoul(argv[0], &end, 10);
- if (*end != '\0')
- return 1;
-
- NLA_PUT_U32(msg, NL80211_ATTR_WIPHY_FREQ, freq);
- argv++;
- argc--;
+ err = parse_freqchan(&chandef, false, argc, argv, &parsed);
- /* channel width */
- for (i = 0; i < ARRAY_SIZE(chanmode); i++) {
- if (strcasecmp(chanmode[i].name, argv[0]) == 0) {
- chanmode_selected = &chanmode[i];
- break;
- }
- }
- if (chanmode_selected) {
- NLA_PUT_U32(msg, NL80211_ATTR_CHANNEL_WIDTH,
- chanmode_selected->width);
- NLA_PUT_U32(msg, NL80211_ATTR_CENTER_FREQ1,
- get_cf1(chanmode_selected, freq));
+ if (err)
+ return err;
- argv++;
- argc--;
- } else {
- return 1;
- }
+ put_chandef(msg, &chandef);
+ if (err)
+ return err;
return 0;
-
-nla_put_failure:
- return -ENOBUFS;
}
COMMAND(ocb, join, "<freq in MHz> <5MHz|10MHz>",
NL80211_CMD_JOIN_OCB, 0, CIB_NETDEV, join_ocb,
--
2.13.6
next prev parent reply other threads:[~2017-12-13 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 21:43 [PATCH 1/1] ocb: Use common freqchan helper for setting the operating channel Peter Große
2017-12-11 11:17 ` Johannes Berg
2017-12-13 12:58 ` Peter Große [this message]
2017-12-13 13:00 ` [PATCH] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213125840.1036-1-pegro@friiks.de \
--to=pegro@friiks.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).