Re: [PATCH] mac80211: Fix setting TX power on monitor interfaces

["Peter Große" <pegro@friiks.de>]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Tue, 19 Dec 2017 10:53:30 +0100
Johannes Berg <johannes@sipsolutions.net> wrote:

> > +	if (has_monitor) {
> > +		sdata = rtnl_dereference(local->monitor_sdata);
> > +		if (sdata) {
> > +			sdata->user_power_level = local->user_power_level;
> > +			if (txp_type != sdata->vif.bss_conf.txpower_type)
> > +				update_txp_type = true;
> > +			sdata->vif.bss_conf.txpower_type = txp_type;
> > +
> > +			ieee80211_recalc_txpower(sdata, update_txp_type);
> > +		}
> > +	}  
> 
> But do we really need this? I think we can probably live with just not
> having monitor handled here, i.e. only have the "if monitor continue;"
> part?

I don't mind. I just thought, if I call ieee80211_recalc_txpower on the
monitor_sdata interface when called explicitly, I would also do it when
iterating over all interfaces, just to be consistent. I don't know, whether
there are drivers out there, that store power limits on monitor interfaces
separately for injection or whatever.

I can send a patch without the quoted part.

Regards
Peter

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]