From: Kalle Valo <kvalo@codeaurora.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org, luca@coelho.fi,
sara.sharon@intel.com, stable@vger.kernel.org
Subject: Re: iwlwifi: pcie: fix DMA memory mapping / unmapping
Date: Fri, 5 Jan 2018 11:55:33 +0000 (UTC) [thread overview]
Message-ID: <20180105115533.70D616079C@smtp.codeaurora.org> (raw)
In-Reply-To: <20180104071913.15470-1-emmanuel.grumbach@intel.com>
Emmanuel Grumbach <emmanuel.grumbach@intel.com> wrote:
> 22000 devices (previously referenced as A000) can support
> short transmit queues. This means that we have less DMA
> descriptors (TFD) for those shorter queues.
> Previous devices must still have 256 TFDs for each queue
> even if those 256 TFDs point to fewer buffers.
>
> When I introduced support for the short queues for 22000
> I broke older devices by assuming that they can also have
> less TFDs in their queues. This led to several problems:
>
> 1) the payload of the commands weren't unmapped properly
> which caused the SWIOTLB to complain at some point.
> 2) the hardware could get confused and we get hardware
> crashes.
>
> The corresponding bugzilla entries are:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=198201
> https://bugzilla.kernel.org/show_bug.cgi?id=198265
>
> Cc: stable@vger.kernel.org # 4.14+
> Fixes: 4ecab5616023 ("iwlwifi: pcie: support short Tx queues for A000 device family")
> Reviewed-by: Sharon, Sara <sara.sharon@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Patch applied to wireless-drivers.git, thanks.
943309d4aad6 iwlwifi: pcie: fix DMA memory mapping / unmapping
--
https://patchwork.kernel.org/patch/10143989/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-01-05 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 7:19 [PATCH] iwlwifi: pcie: fix DMA memory mapping / unmapping Emmanuel Grumbach
2018-01-04 14:42 ` Kalle Valo
2018-01-05 11:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105115533.70D616079C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=sara.sharon@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).