From: William Dauchy <wdauchy@gmail.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: brcmfmac: set p2p_disc error on BCM4350
Date: Mon, 8 Jan 2018 11:30:12 +0100 [thread overview]
Message-ID: <20180108103012.GA1957@paf> (raw)
In-Reply-To: <5A533A88.1000804@broadcom.com>
Hello Arend,
Thanks for your quick answer.
On Mon, Jan 08, 2018 at 10:31:52AM +0100, Arend van Spriel wrote:
> This has been reported before, but not been able to look into it. Diving
> into firmware it seems that error can only occur if the mac address for the
> p2pdev interface is already used. So if possible can you rebuild the driver
> with the patch below applied and provide dmesg output and output of
> 'ifconfig -a'.
>
> Regards,
> Arend
> ---8<----------------------------------------------------------------
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> b/drivers/n
> index 2ee5413..f96ad37 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -2065,6 +2065,7 @@ static struct wireless_dev
> *brcmf_p2p_create_p2pdev(struc
> int err;
> u32 bsscfgidx;
>
> + brcmf_err("enter: mac=%pM\n", addr);
> if (p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif)
> return ERR_PTR(-ENOSPC);
>
>
Here is my brcmfmac dmesg output with patch applied
(please tell me if you need complete dmesg)
brcmfmac: brcmf_fw_map_chip_to_name: using brcm/brcmfmac4350-pcie.bin for chip 0x004350(17232) rev 0x000008
brcmfmac 0000:3a:00.0: Direct firmware load for brcm/brcmfmac4350-pcie.txt failed with error -2
brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Oct 22 2015 06:16:26 version 7.35.180.119 (r594535) FWID 01-e791c176
brcmfmac 0000:3a:00.0 wlp58s0: renamed from wlan0
brcmfmac: brcmf_p2p_create_p2pdev: enter: mac=00:00:00:00:00:00
brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error
brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp58s0 type 10 failed: err=-16
ifconfig shows:
wlp58s0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
inet 192.168.18.77 netmask 255.255.255.0 broadcast 192.168.18.255
inet6 fe80::3517:e1be:5bc7:899 prefixlen 64 scopeid 0x20<link>
ether 30:52:cb:83:71:33 txqueuelen 1000 (Ethernet)
RX packets 26557 bytes 34149730 (32.5 MiB)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 14965 bytes 2298777 (2.1 MiB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
Best,
--
William
next prev parent reply other threads:[~2018-01-08 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 23:49 brcmfmac: set p2p_disc error on BCM4350 William Dauchy
2018-01-08 9:31 ` Arend van Spriel
2018-01-08 10:30 ` William Dauchy [this message]
2018-01-15 10:29 ` William Dauchy
2018-01-15 19:48 ` Arend van Spriel
2018-01-15 20:03 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108103012.GA1957@paf \
--to=wdauchy@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).