From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Singh <ajay.kathat@microchip.com>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
venkateswara.kaja@microchip.com, ganesh.krishna@microchip.com,
aditya.shankar@microchip.com
Subject: Re: [PATCH v2 5/9] staging: wilc1000: removed few unnecessary enums typedef
Date: Wed, 10 Jan 2018 19:25:13 +0100 [thread overview]
Message-ID: <20180110182513.GA24654@kroah.com> (raw)
In-Reply-To: <1515582771-28408-6-git-send-email-ajay.kathat@microchip.com>
On Wed, Jan 10, 2018 at 04:42:47PM +0530, Ajay Singh wrote:
> This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T,
> N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum.
> Now, these enums are used as anonymous-enums for constants.
>
> checkpatch.pl warning to not add new typedef is fixes with this patch.
>
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
> drivers/staging/wilc1000/wilc_wlan_if.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
This is the same subject line as the previous patch in the series, yet
they are doing different things.
Please take this series and work on the subject lines to make them a bit
more unique and different from each other, and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2018-01-10 18:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 11:12 [PATCH v2 0/9] fixes to remove enum typedefs Ajay Singh
2018-01-10 11:12 ` [PATCH v2 1/9] staging: wilc1000: removed typedef from enum BSSTYPE_T Ajay Singh
2018-01-10 11:12 ` [PATCH v2 2/9] staging: wilc1000: remove unnecessary typedef enum G_OPERATING_MODE_T Ajay Singh
2018-01-10 11:12 ` [PATCH v2 3/9] staging: wilc1000: removed unnecessary enums typedefs Ajay Singh
2018-01-10 11:12 ` [PATCH v2 4/9] staging: wilc1000: removed few unnecessary enums typedef Ajay Singh
2018-01-10 11:12 ` [PATCH v2 5/9] " Ajay Singh
2018-01-10 18:25 ` Greg KH [this message]
2018-01-10 11:12 ` [PATCH v2 6/9] staging: wilc1000: removed enums typedef for BEACON_IE & TX_RATE_T Ajay Singh
2018-01-10 11:12 ` [PATCH v2 7/9] staging: wilc1000: removed enum typedef CHIP_PS_STATE_T Ajay Singh
2018-01-10 11:12 ` [PATCH v2 8/9] staging: wilc1000: removed enum typedef BUS_ACQUIRE_T Ajay Singh
2018-01-10 11:12 ` [PATCH v2 9/9] staging: wilc1000: removed enum typedef BUS_RELEASE_T Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110182513.GA24654@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aditya.shankar@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).