From: Kalle Valo <kvalo@codeaurora.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"Guenter Roeck" <linux@roeck-us.net>,
"Matt Redfearn" <matt.redfearn@imgtec.com>,
"James Hogan" <jhogan@kernel.org>
Subject: Re: bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
Date: Tue, 16 Jan 2018 19:15:36 +0000 (UTC) [thread overview]
Message-ID: <20180116191536.7CF82602BA@smtp.codeaurora.org> (raw)
In-Reply-To: <1515965642-16259-1-git-send-email-linux@roeck-us.net>
Guenter Roeck <linux@roeck-us.net> wrote:
> Mips builds with BCMA host mode enabled fail in mainline and -next
> with:
>
> In file included from include/linux/bcma/bcma.h:10:0,
> from drivers/bcma/bcma_private.h:9,
> from drivers/bcma/main.c:8:
> include/linux/bcma/bcma_driver_pci.h:218:24: error:
> field 'pci_controller' has incomplete type
>
> Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS
> system type as generic") as the culprit. Analysis shows that the commmit
> changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
> disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
> defined if PCI_DRIVERS_LEGACY is enabled.
>
> Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
> PCI_DRIVERS_LEGACY. Add the missing dependency.
>
> Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...")
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: James Hogan <jhogan@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Reviewed-by: James Hogan <jhogan@kernel.org>
Patch applied to wireless-drivers.git, thanks.
664eadd6f44b bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
--
https://patchwork.kernel.org/patch/10162839/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-01-16 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 21:34 [PATCH] bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets Guenter Roeck
2018-01-14 21:40 ` Guenter Roeck
2018-01-15 10:11 ` Kalle Valo
2018-01-15 10:03 ` Kalle Valo
2018-01-15 10:23 ` James Hogan
2018-01-15 17:10 ` Paul Burton
2018-01-15 20:05 ` Guenter Roeck
2018-01-15 20:30 ` James Hogan
2018-01-15 20:58 ` Guenter Roeck
2018-01-16 19:15 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116191536.7CF82602BA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.redfearn@imgtec.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).