* [PATCH] ssb: Do not disable PCI host on non-Mips
@ 2018-01-26 9:38 Sven Joachim
2018-01-26 10:09 ` James Hogan
2018-01-26 14:56 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: Sven Joachim @ 2018-01-26 9:38 UTC (permalink / raw)
To: Michael Buesch, linux-wireless
Cc: James Hogan, linux-mips, Ralf Baechle, James Hogan, Paul Burton,
Matt Redfearn, Guenter Roeck
After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
wlan0 interfaces had disappeared. It turns out that the b43 and b44
drivers require SSB_PCIHOST_POSSIBLE which depends on
PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
Cc: stable@vger.org
Signed-off-by: Sven Joachim <svenjoac@gmx.de>
---
drivers/ssb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 71c73766ee22..65af12c3bdb2 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -32,7 +32,7 @@ config SSB_BLOCKIO
config SSB_PCIHOST_POSSIBLE
bool
- depends on SSB && (PCI = y || PCI = SSB) && PCI_DRIVERS_LEGACY
+ depends on SSB && (PCI = y || PCI = SSB) && (PCI_DRIVERS_LEGACY || !MIPS)
default y
config SSB_PCIHOST
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ssb: Do not disable PCI host on non-Mips
2018-01-26 9:38 [PATCH] ssb: Do not disable PCI host on non-Mips Sven Joachim
@ 2018-01-26 10:09 ` James Hogan
2018-01-26 14:37 ` Kalle Valo
2018-01-26 14:56 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: James Hogan @ 2018-01-26 10:09 UTC (permalink / raw)
To: Sven Joachim
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
Paul Burton, Matt Redfearn, Guenter Roeck, Kalle Valo
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
On Fri, Jan 26, 2018 at 10:38:01AM +0100, Sven Joachim wrote:
> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
> wlan0 interfaces had disappeared. It turns out that the b43 and b44
> drivers require SSB_PCIHOST_POSSIBLE which depends on
> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
>
> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
> Cc: stable@vger.org
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
Whoops, thats a very good point. I hadn't twigged that
PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using
"tig grep" I suppose!).
Reviewed-by: James Hogan <jhogan@kernel.org>
I think this is obviously correct, so it'd be great to squeeze it into
4.15 final.
Fortunately the other related change, commit 664eadd6f44b ("bcma: Fix
'allmodconfig' and BCMA builds on MIPS targets"), already depends on
MIPS so doesn't have the same issue.
Sorry for the breakage!
James
> ---
> drivers/ssb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index 71c73766ee22..65af12c3bdb2 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -32,7 +32,7 @@ config SSB_BLOCKIO
>
> config SSB_PCIHOST_POSSIBLE
> bool
> - depends on SSB && (PCI = y || PCI = SSB) && PCI_DRIVERS_LEGACY
> + depends on SSB && (PCI = y || PCI = SSB) && (PCI_DRIVERS_LEGACY || !MIPS)
> default y
>
> config SSB_PCIHOST
> --
> 2.15.1
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ssb: Do not disable PCI host on non-Mips
2018-01-26 10:09 ` James Hogan
@ 2018-01-26 14:37 ` Kalle Valo
2018-01-26 17:01 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2018-01-26 14:37 UTC (permalink / raw)
To: James Hogan
Cc: Sven Joachim, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> writes:
> On Fri, Jan 26, 2018 at 10:38:01AM +0100, Sven Joachim wrote:
>> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
>> wlan0 interfaces had disappeared. It turns out that the b43 and b44
>> drivers require SSB_PCIHOST_POSSIBLE which depends on
>> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
>>
>> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
>> Cc: stable@vger.org
>> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
>
> Whoops, thats a very good point. I hadn't twigged that
> PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using
> "tig grep" I suppose!).
>
> Reviewed-by: James Hogan <jhogan@kernel.org>
>
> I think this is obviously correct, so it'd be great to squeeze it into
> 4.15 final.
I'm not sure if I'm able to get it to 4.15 as it has go via the net
tree, and we have only two days before the (likely) final release, but
I'll try.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ssb: Do not disable PCI host on non-Mips
2018-01-26 14:37 ` Kalle Valo
@ 2018-01-26 17:01 ` Kalle Valo
2018-01-26 17:45 ` James Hogan
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2018-01-26 17:01 UTC (permalink / raw)
To: James Hogan
Cc: Sven Joachim, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
Kalle Valo <kvalo@codeaurora.org> writes:
> James Hogan <jhogan@kernel.org> writes:
>
>> On Fri, Jan 26, 2018 at 10:38:01AM +0100, Sven Joachim wrote:
>>> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
>>> wlan0 interfaces had disappeared. It turns out that the b43 and b44
>>> drivers require SSB_PCIHOST_POSSIBLE which depends on
>>> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
>>>
>>> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
>>> Cc: stable@vger.org
>>> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
>>
>> Whoops, thats a very good point. I hadn't twigged that
>> PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using
>> "tig grep" I suppose!).
>>
>> Reviewed-by: James Hogan <jhogan@kernel.org>
>>
>> I think this is obviously correct, so it'd be great to squeeze it into
>> 4.15 final.
>
> I'm not sure if I'm able to get it to 4.15 as it has go via the net
> tree, and we have only two days before the (likely) final release, but
> I'll try.
Too late, Dave already sent his last pull request for 4.15. This will be
in 4.16.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ssb: Do not disable PCI host on non-Mips
2018-01-26 17:01 ` Kalle Valo
@ 2018-01-26 17:45 ` James Hogan
0 siblings, 0 replies; 6+ messages in thread
From: James Hogan @ 2018-01-26 17:45 UTC (permalink / raw)
To: Kalle Valo
Cc: Sven Joachim, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On Fri, Jan 26, 2018 at 07:01:49PM +0200, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
> > James Hogan <jhogan@kernel.org> writes:
> >
> >> On Fri, Jan 26, 2018 at 10:38:01AM +0100, Sven Joachim wrote:
> >>> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
> >>> wlan0 interfaces had disappeared. It turns out that the b43 and b44
> >>> drivers require SSB_PCIHOST_POSSIBLE which depends on
> >>> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
> >>>
> >>> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
> >>> Cc: stable@vger.org
> >>> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
> >>
> >> Whoops, thats a very good point. I hadn't twigged that
> >> PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using
> >> "tig grep" I suppose!).
> >>
> >> Reviewed-by: James Hogan <jhogan@kernel.org>
> >>
> >> I think this is obviously correct, so it'd be great to squeeze it into
> >> 4.15 final.
> >
> > I'm not sure if I'm able to get it to 4.15 as it has go via the net
> > tree, and we have only two days before the (likely) final release, but
> > I'll try.
>
> Too late, Dave already sent his last pull request for 4.15. This will be
> in 4.16.
Okay, thanks anyway (and sorry again!).
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ssb: Do not disable PCI host on non-Mips
2018-01-26 9:38 [PATCH] ssb: Do not disable PCI host on non-Mips Sven Joachim
2018-01-26 10:09 ` James Hogan
@ 2018-01-26 14:56 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-01-26 14:56 UTC (permalink / raw)
To: Sven Joachim
Cc: Michael Buesch, linux-wireless, James Hogan, linux-mips,
Ralf Baechle, James Hogan, Paul Burton, Matt Redfearn,
Guenter Roeck
Sven Joachim <svenjoac@gmx.de> wrote:
> After upgrading an old laptop to 4.15-rc9, I found that the eth0 and
> wlan0 interfaces had disappeared. It turns out that the b43 and b44
> drivers require SSB_PCIHOST_POSSIBLE which depends on
> PCI_DRIVERS_LEGACY, a config option that only exists on Mips.
>
> Fixes: 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")
> Cc: stable@vger.org
> Signed-off-by: Sven Joachim <svenjoac@gmx.de>
> Reviewed-by: James Hogan <jhogan@kernel.org>
Patch applied to wireless-drivers.git, thanks.
a9e6d44ddecc ssb: Do not disable PCI host on non-Mips
--
https://patchwork.kernel.org/patch/10185397/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-26 17:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-26 9:38 [PATCH] ssb: Do not disable PCI host on non-Mips Sven Joachim
2018-01-26 10:09 ` James Hogan
2018-01-26 14:37 ` Kalle Valo
2018-01-26 17:01 ` Kalle Valo
2018-01-26 17:45 ` James Hogan
2018-01-26 14:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).