From: Ajay Singh <ajay.kathat@microchip.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild test robot <lkp@intel.com>, <devel@driverdev.osuosl.org>,
<venkateswara.kaja@microchip.com>, <gregkh@linuxfoundation.org>,
<linux-wireless@vger.kernel.org>, <ganesh.krishna@microchip.com>,
<kbuild-all@01.org>, <aditya.shankar@microchip.com>
Subject: Re: [PATCH v2 13/14] staging: wilc1000: rename Handle_Connect() to avoid camelCase
Date: Tue, 30 Jan 2018 21:40:21 +0530 [thread overview]
Message-ID: <20180130214021.5fdd1aa3@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180130144031.hd5whcs4lwah4qhs@mwanda>
On Tue, 30 Jan 2018 17:40:31 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Jan 30, 2018 at 07:29:49PM +0530, Ajay Singh wrote:
> > On Tue, 30 Jan 2018 02:13:53 +0800
> > kbuild test robot <lkp@intel.com> wrote:
> >
>
> >
> >
> > The patch only change variable names to avoid the camelCase, didn't modify any extra code to dereference memory.
>
> You are responding to a robot and I think we all understood that this
> warning was there before you renamed the variables.
>
Thanks, got it.
> > I think, with the use of shorter variable name now memcpy() is taking 1 line instead of 3 lines. So, now line 937 has different code line(as code is swifted up by few lines).So because of that new potential NULL dereference error is popped up for same existing code.
> > The code to validate dynamically allocated memory before access, will be include in separate patch to keep it segregated from variable names changes.
> > I will rework on this patch and resend again.
>
> There is no need to re-work the patch.
>
Few of the patches for patch series are accepted and submitted to "linux-next". For now, will submit the a new patch series by including the remaining patches (changing commit subject line to avoid confusion from previous patches).
> You are right that the NULL check should be added as a separate check.
>
> regards,
> dan carpenter
>
Regards,
Ajay
next prev parent reply other threads:[~2018-01-30 16:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:22 [PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase Ajay Singh
2018-01-22 10:22 ` [PATCH v2 01/14] staging: wilc1000: remove unnecessary use of parentheses Ajay Singh
2018-01-22 10:22 ` [PATCH v2 02/14] staging: wilc1000: removed unnecessary defined enums typedef Ajay Singh
2018-01-22 11:06 ` Claudiu Beznea
2018-01-22 11:22 ` Dan Carpenter
2018-01-22 11:32 ` Claudiu Beznea
2018-01-22 10:22 ` [PATCH v2 03/14] staging: wilc1000: fix alignments to match open parenthesis Ajay Singh
2018-01-22 10:22 ` [PATCH v2 04/14] staging: wilc1000: rename host_int_ParseJoinBssParam() and it's variable using camelCase Ajay Singh
2018-01-22 11:13 ` Claudiu Beznea
2018-01-22 10:22 ` [PATCH v2 05/14] staging: wilc1000: rename camelCase used in Handle_DelAllSta() and its variable Ajay Singh
2018-01-22 10:22 ` [PATCH v2 06/14] staging: wilc1000: rename strWIDList variable to wid_list to avoid camelCase Ajay Singh
2018-01-22 10:22 ` [PATCH v2 07/14] staging: wilc1000: rename u32WidsCount variable " Ajay Singh
2018-01-22 10:22 ` [PATCH v2 08/14] staging: wilc1000: rename pu8CurrByte " Ajay Singh
2018-01-22 10:22 ` [PATCH v2 09/14] staging: wilc1000: rename pstrHostIFconnectAttr argument " Ajay Singh
2018-01-22 10:22 ` [PATCH v2 10/14] staging: wilc1000: rename ptstrJoinBssParam variable " Ajay Singh
2018-01-22 10:22 ` [PATCH v2 11/14] staging: wilc1000: rename strConnectInfo " Ajay Singh
2018-01-22 10:22 ` [PATCH v2 12/14] staging: wilc1000: rename Handle_ScanDone() " Ajay Singh
2018-01-22 11:07 ` Claudiu Beznea
2018-01-22 10:22 ` [PATCH v2 13/14] staging: wilc1000: rename Handle_Connect() " Ajay Singh
2018-01-22 11:08 ` Claudiu Beznea
2018-01-29 18:13 ` kbuild test robot
2018-01-30 13:59 ` Ajay Singh
2018-01-30 14:40 ` Dan Carpenter
2018-01-30 16:10 ` Ajay Singh [this message]
2018-01-30 14:36 ` Dan Carpenter
2018-01-22 10:22 ` [PATCH v2 14/14] staging: wilc1000: rename Handle_ConnectTimeout() and Handle_Key() Ajay Singh
2018-01-22 11:10 ` [PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase Claudiu Beznea
2018-01-22 11:15 ` Claudiu Beznea
2018-01-22 11:54 ` Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130214021.5fdd1aa3@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).