* [PATCH] ath9k: Fix get channel default noise floor
@ 2018-01-26 14:20 Wojciech Dubowik
2018-01-26 14:24 ` Sebastian Gottschall
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wojciech Dubowik @ 2018-01-26 14:20 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, ath9k-devel, Wojciech Dubowik
Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
when available") introduced regression in ath9k_hw_getchan_noise
where per chain nominal noise floor has been taken instead default
for channel.
Revert to original default channel noise floor.
Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
---
drivers/net/wireless/ath/ath9k/calib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
index 3d9447e..695c779 100644
--- a/drivers/net/wireless/ath/ath9k/calib.c
+++ b/drivers/net/wireless/ath/ath9k/calib.c
@@ -72,7 +72,7 @@ static s16 ath9k_hw_get_default_nf(struct ath_hw *ah,
s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan,
s16 nf)
{
- s8 noise = ath9k_hw_get_default_nf(ah, chan, 0);
+ s8 noise = ATH_DEFAULT_NOISE_FLOOR;
if (nf) {
s8 delta = nf - ATH9K_NF_CAL_NOISE_THRESH -
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k: Fix get channel default noise floor
2018-01-26 14:20 [PATCH] ath9k: Fix get channel default noise floor Wojciech Dubowik
@ 2018-01-26 14:24 ` Sebastian Gottschall
2018-01-26 14:35 ` Kalle Valo
2018-02-07 14:14 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Sebastian Gottschall @ 2018-01-26 14:24 UTC (permalink / raw)
To: Wojciech Dubowik, linux-wireless; +Cc: kvalo, ath9k-devel
let me check
Am 26.01.2018 um 15:20 schrieb Wojciech Dubowik:
> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
> ---
> drivers/net/wireless/ath/ath9k/calib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
> index 3d9447e..695c779 100644
> --- a/drivers/net/wireless/ath/ath9k/calib.c
> +++ b/drivers/net/wireless/ath/ath9k/calib.c
> @@ -72,7 +72,7 @@ static s16 ath9k_hw_get_default_nf(struct ath_hw *ah,
> s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan,
> s16 nf)
> {
> - s8 noise = ath9k_hw_get_default_nf(ah, chan, 0);
> + s8 noise = ATH_DEFAULT_NOISE_FLOOR;
>
> if (nf) {
> s8 delta = nf - ATH9K_NF_CAL_NOISE_THRESH -
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k: Fix get channel default noise floor
2018-01-26 14:20 [PATCH] ath9k: Fix get channel default noise floor Wojciech Dubowik
2018-01-26 14:24 ` Sebastian Gottschall
@ 2018-01-26 14:35 ` Kalle Valo
2018-01-26 15:06 ` Sebastian Gottschall
2018-02-07 14:14 ` Kalle Valo
2 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2018-01-26 14:35 UTC (permalink / raw)
To: Wojciech Dubowik; +Cc: linux-wireless, ath9k-devel
Wojciech Dubowik <Wojciech.Dubowik@neratec.com> writes:
> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")
I can add that if this passes Sebastian's tests.
And I'm planning to queue this for 4.16.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath9k: Fix get channel default noise floor
2018-01-26 14:35 ` Kalle Valo
@ 2018-01-26 15:06 ` Sebastian Gottschall
0 siblings, 0 replies; 5+ messages in thread
From: Sebastian Gottschall @ 2018-01-26 15:06 UTC (permalink / raw)
To: Kalle Valo, Wojciech Dubowik; +Cc: linux-wireless, ath9k-devel
the regression has been solved with that patch. so noise floor looks
normal for me on the 9280 chipset again
Am 26.01.2018 um 15:35 schrieb Kalle Valo:
> Wojciech Dubowik <Wojciech.Dubowik@neratec.com> writes:
>
>> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
>> when available") introduced regression in ath9k_hw_getchan_noise
>> where per chain nominal noise floor has been taken instead default
>> for channel.
>> Revert to original default channel noise floor.
>>
>> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
>> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
> Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")
>
> I can add that if this passes Sebastian's tests.
>
> And I'm planning to queue this for 4.16.
>
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ath9k: Fix get channel default noise floor
2018-01-26 14:20 [PATCH] ath9k: Fix get channel default noise floor Wojciech Dubowik
2018-01-26 14:24 ` Sebastian Gottschall
2018-01-26 14:35 ` Kalle Valo
@ 2018-02-07 14:14 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2018-02-07 14:14 UTC (permalink / raw)
To: Wojciech Dubowik; +Cc: linux-wireless, ath9k-devel, Wojciech Dubowik
Wojciech Dubowik <Wojciech.Dubowik@neratec.com> wrote:
> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")
> Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-current branch of ath.git, thanks.
b9607de6cf22 ath9k: Fix get channel default noise floor
--
https://patchwork.kernel.org/patch/10186025/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-07 14:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-26 14:20 [PATCH] ath9k: Fix get channel default noise floor Wojciech Dubowik
2018-01-26 14:24 ` Sebastian Gottschall
2018-01-26 14:35 ` Kalle Valo
2018-01-26 15:06 ` Sebastian Gottschall
2018-02-07 14:14 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).