linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timothy Redaelli <tredaelli@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: <linux-wireless@vger.kernel.org>,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] ath9k: fix DFS detector synchronization
Date: Fri, 9 Feb 2018 15:33:11 +0100	[thread overview]
Message-ID: <20180209153311.193e08e0@redhat.com> (raw)
In-Reply-To: <87fu6aegmy.fsf@kamboji.qca.qualcomm.com>

On Fri, 09 Feb 2018 10:01:09 +0200
Kalle Valo <kvalo@codeaurora.org> wrote:

> Timothy Redaelli <tredaelli@redhat.com> writes:
> 
> > The code currently syncronize the DFS region only if curchan != 0,
> > but hostapd launch DFS before the channel is set and so
> > set_dfs_domain is never executed.
> >
> > CC: Felix Fietkau <nbd@nbd.name>
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>  
> 
> What kind of bug does this fix? Please describe the symptoms from
> user's point of view.

With the current code radar detection (CAC) doesn't work on ath9k
since "dpd_set_domain" is only called once with NL80211_DFS_UNSET (0) as
region and so "dpd_add_pulse" always returns true (radar detected)
without doing a real scan.

You can test it easily with a kernel built with
CONFIG_ATH9K_DFS_CERTIFIED and by using a simple hostapd configuration:

interface=wlp1s0
hw_mode=a
channel=acs_survey
chanlist=100 104 108 112 116 120 124 128 132 136 140
ieee80211d=1
ieee80211h=1
country_code=US
ieee80211n=1
wmm_enabled=1
ssid=testwifi

  reply	other threads:[~2018-02-09 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08 11:46 [PATCH] ath9k: fix DFS detector synchronization Timothy Redaelli
2018-02-09  8:01 ` Kalle Valo
2018-02-09 14:33   ` Timothy Redaelli [this message]
2018-02-12 12:44     ` Kalle Valo
2018-02-12 15:27       ` Zefir Kurtisi
2018-02-12 18:40 ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180209153311.193e08e0@redhat.com \
    --to=tredaelli@redhat.com \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).