From: Jakub Kicinski <kubakici@wp.pl>
To: cantabile <cantabile.desu@gmail.com>
Cc: mcgrof@kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt7601u: Fix system freeze after resuming from hibernation
Date: Sun, 18 Feb 2018 21:55:20 -0800 [thread overview]
Message-ID: <20180218215520.65c1e9fd@cakuba.netronome.com> (raw)
In-Reply-To: <7cebda93-4b7a-e8b3-271f-0144c5e94248@gmail.com>
On Sat, 17 Feb 2018 13:23:29 +0200, cantabile wrote:
> > Thanks for the info. Would it be cleaner to EXPORT fw_add_devm_name()
> > and just call that in case driver sees FW is already loaded? That
> > should inform the fw subsystem that we want the image around in case of
> > hibernation, but there is no need to load it immediately?
>
> No, I don't believe it's cleaner to expose a private function that you
> don't even really need. Remember that calling request_firmware every
> time your driver's probe and resume functions are called is normal. It's
> the expected behaviour.
I'm asking you the extend functionality of a subsystem to be able to
cleanly communicate the intent. Not export internal functions.
Requesting firmware you don't need and risking failing probe even if FW
is already pre-loaded is not correct. Reordering you suggest is
brittle and makes little logical sense unless someone guesses your use
case.
Please at least try to do as advised. Otherwise:
Nacked-by: Jakub Kicinski <kubakici@wp.pl>
next prev parent reply other threads:[~2018-02-19 5:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:34 [PATCH] mt7601u: Fix system freeze after resuming from hibernation cantabile
2018-02-15 0:45 ` Jakub Kicinski
2018-02-15 11:38 ` cantabile
2018-02-15 21:47 ` Jakub Kicinski
2018-02-17 11:23 ` cantabile
2018-02-19 5:55 ` Jakub Kicinski [this message]
2018-02-19 15:01 ` cantabile
2018-02-25 17:54 ` Luis R. Rodriguez
2018-02-27 2:28 ` Jakub Kicinski
2018-02-27 12:25 ` cantabile
2018-02-27 16:54 ` Luis R. Rodriguez
2018-02-27 18:22 ` Jakub Kicinski
2018-02-27 20:42 ` Luis R. Rodriguez
2018-02-28 18:02 ` cantabile
2018-02-28 18:48 ` Luis R. Rodriguez
2018-02-28 19:18 ` Arend van Spriel
2018-02-28 20:41 ` Luis R. Rodriguez
2018-02-28 21:18 ` cantabile
2018-03-01 0:28 ` Luis R. Rodriguez
2018-03-01 14:05 ` cantabile
2018-03-01 17:29 ` Luis R. Rodriguez
2018-03-01 20:11 ` cantabile
2018-03-01 21:01 ` Luis R. Rodriguez
2018-03-02 10:43 ` cantabile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218215520.65c1e9fd@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=cantabile.desu@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).