Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ajay Singh <ajay.kathat@microchip.com>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	venkateswara.kaja@microchip.com, gregkh@linuxfoundation.org,
	ganesh.krishna@microchip.com, aditya.shankar@microchip.com
Subject: Re: [PATCH 04/12] staging: wilc1000: fix open parenthesis alignment mismatch in wilc_parse_network_info()
Date: Mon, 19 Feb 2018 11:56:02 +0300	[thread overview]
Message-ID: <20180219085602.i3gxyofwraimiptw@mwanda> (raw)
In-Reply-To: <1518793909-15573-5-git-send-email-ajay.kathat@microchip.com>

On Fri, Feb 16, 2018 at 08:41:41PM +0530, Ajay Singh wrote:
> Fix "Alignment should match open parenthesis" issue found by
> checkpatch.pl script.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index e98fc8e..2e2187b 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -320,8 +320,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
>  		get_ssid(msa, network_info->ssid, &network_info->ssid_len);
>  		get_BSSID(msa, network_info->bssid);
>  
> -		network_info->ch = get_current_channel_802_11n(msa,
> -							rx_len + FCS_LEN);
> +		network_info->ch = get_current_channel_802_11n(msa, rx_len
> +							       + FCS_LEN);

Greg has already applied this which is fine, but I probably would have
left this as is.  Normally a rule is that the '+' character should be on
the first line, and also it's slightly easier to read when the argument
is one one line instead of split across two.

But it doesn't matter much either way.  We'll probably end up
re-writing great swaths of this code.

regards,
dan carpenter

  reply	other threads:[~2018-02-19  8:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 15:11 [PATCH 00/12] fix to remove line over 80 chars and few other Ajay Singh
2018-02-16 15:11 ` [PATCH 01/12] staging: wilc1000: remove unnecessary comments to avoid line over 80 char issue Ajay Singh
2018-02-16 15:11 ` [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext() Ajay Singh
2018-02-19 13:33   ` Claudiu Beznea
2018-02-21 16:25     ` Ajay Singh
2018-02-21 16:33       ` Claudiu Beznea
2018-02-16 15:11 ` [PATCH 03/12] staging: wilc1000: fix line over 80 characters " Ajay Singh
2018-02-16 15:11 ` [PATCH 04/12] staging: wilc1000: fix open parenthesis alignment mismatch in wilc_parse_network_info() Ajay Singh
2018-02-19  8:56   ` Dan Carpenter [this message]
2018-02-16 15:11 ` [PATCH 05/12] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set_str() Ajay Singh
2018-02-16 15:11 ` [PATCH 06/12] staging: wilc1000: remove blank line before close brace in wilc_wlan_cfg_get_wid_value() Ajay Singh
2018-02-16 15:11 ` [PATCH 07/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_cfg_indicate_rxi() Ajay Singh
2018-02-16 15:11 ` [PATCH 08/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_cfg_get_wid_value() Ajay Singh
2018-02-16 15:11 ` [PATCH 09/12] staging: wilc1000: fix line over 80 chars in add_tcp_pending_ack() Ajay Singh
2018-02-16 15:11 ` [PATCH 10/12] staging: wilc1000: fix line over 80 characters in tcp_process() Ajay Singh
2018-02-16 15:11 ` [PATCH 11/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack() Ajay Singh
2018-02-19 13:41   ` Claudiu Beznea
2018-02-16 15:11 ` [PATCH 12/12] staging: wilc1000: fix line over 80 chars in wilc_wlan_handle_txq() Ajay Singh
2018-02-16 16:30 ` [PATCH 00/12] fix to remove line over 80 chars and few other Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219085602.i3gxyofwraimiptw@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=aditya.shankar@microchip.com \
    --cc=ajay.kathat@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=ganesh.krishna@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=venkateswara.kaja@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox