From: Ajay Singh <ajay.kathat@microchip.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<venkateswara.kaja@microchip.com>, <ganesh.krishna@microchip.com>,
<aditya.shankar@microchip.com>
Subject: Re: [PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init()
Date: Mon, 19 Feb 2018 12:07:41 +0530 [thread overview]
Message-ID: <20180219120741.19232d40@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180216143022.GA20682@kroah.com>
On Fri, 16 Feb 2018 15:30:22 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:
> > diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
> > index 30a9a61..fddc0db 100644
> > --- a/drivers/staging/wilc1000/wilc_spi.c
> > +++ b/drivers/staging/wilc1000/wilc_spi.c
> > @@ -835,7 +835,6 @@ static int wilc_spi_init(struct wilc *wilc, bool resume)
> > struct spi_device *spi = to_spi_device(wilc->dev);
> > u32 reg;
> > u32 chipid;
> > -
> > static int isinit;
>
> You also deleted this line :(
The blank line was not necessary between the variable's declaration. I
should have done these changes in separate patch.
I will take care to have these type of changes either in a separate patch
or include the change details in description.
next prev parent reply other threads:[~2018-02-19 6:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:10 [PATCH 0/6] fix line over 80 char & coding style in wilc_spi.c Ajay Singh
2018-02-14 11:10 ` [PATCH 1/6] staging: wilc1000: modified code comments as per linux coding style Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-14 11:10 ` [PATCH 2/6] staging: wilc1000: removed the unnecessary commented code Ajay Singh
2018-02-14 11:10 ` [PATCH 3/6] staging: wilc1000: fix line over 80 characters in spi_cmd_complete() Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-14 11:10 ` [PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init() Ajay Singh
2018-02-16 14:30 ` Greg KH
2018-02-19 6:37 ` Ajay Singh [this message]
2018-02-14 11:10 ` [PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int() Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-19 8:04 ` Ajay Singh
2018-02-14 11:10 ` [PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext() Ajay Singh
2018-02-16 18:16 ` Claudiu Beznea
2018-02-19 7:49 ` Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219120741.19232d40@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).