From: Ajay Singh <ajay.kathat@microchip.com>
To: Claudiu Beznea <Claudiu.Beznea@microchip.com>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<gregkh@linuxfoundation.org>, <ganesh.krishna@microchip.com>,
<venkateswara.kaja@microchip.com>, <aditya.shankar@microchip.com>,
<Adham.Abozaeid@microchip.com>
Subject: Re: [PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext()
Date: Mon, 19 Feb 2018 13:19:36 +0530 [thread overview]
Message-ID: <20180219131936.3e1cbfc2@ajaysk-VirtualBox> (raw)
In-Reply-To: <63adcc58-bdd1-9fe7-6774-3ea1d626858b@microchip.com>
On Fri, 16 Feb 2018 20:16:02 +0200
Claudiu Beznea <Claudiu.Beznea@microchip.com> wrote:
> Or you could use:
> unsigned long expected_irqs, unexpected_irqs;
>
> expected_irqs = val & GENMASK(g_spi.int - 1, 0);
> unexpected_irq = val & GENMASK(MAX_NUM_INT - 1, g_spi.int);
>
> for (i = 0; i < g_spi.nint && expected_irqs; i++) {
> if (expected_irqs & BIT(i)) {
> ret = wilc_spi_write_reg(wilc, 0x10c8 + i * 4, 1);
> if (ret) {
> dev_err(...);
> goto _fail_;
> }
> }
> }
>
> for (i = g_spi.nint; i < MAX_NUM_INT && unexpected_irq; i++) {
> if (unexpected_irqs & BIT(i))
> dev_err(...);
>
Thanks for suggestion.
I will take this input and make use of GENMASK macro to modify the
function. In a separate patch will submit these changes. As there are
other functions,where same macro can be used so will include them
together in separate patch.
prev parent reply other threads:[~2018-02-19 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 11:10 [PATCH 0/6] fix line over 80 char & coding style in wilc_spi.c Ajay Singh
2018-02-14 11:10 ` [PATCH 1/6] staging: wilc1000: modified code comments as per linux coding style Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-14 11:10 ` [PATCH 2/6] staging: wilc1000: removed the unnecessary commented code Ajay Singh
2018-02-14 11:10 ` [PATCH 3/6] staging: wilc1000: fix line over 80 characters in spi_cmd_complete() Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-14 11:10 ` [PATCH 4/6] staging: wilc1000: fix line over 80 characters in wilc_spi_init() Ajay Singh
2018-02-16 14:30 ` Greg KH
2018-02-19 6:37 ` Ajay Singh
2018-02-14 11:10 ` [PATCH 5/6] staging: wilc1000: fix line over 80 characters in wilc_spi_read_int() Ajay Singh
2018-02-16 18:15 ` Claudiu Beznea
2018-02-19 8:04 ` Ajay Singh
2018-02-14 11:10 ` [PATCH 6/6] staging: wilc1000: fix line over 80 chars in wilc_spi_clear_int_ext() Ajay Singh
2018-02-16 18:16 ` Claudiu Beznea
2018-02-19 7:49 ` Ajay Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219131936.3e1cbfc2@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).