* [PATCH] rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle
@ 2018-02-27 1:57 pkshih
2018-02-27 16:26 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: pkshih @ 2018-02-27 1:57 UTC (permalink / raw)
To: kvalo; +Cc: colin.king, Larry.Finger, yhchuang, linux-wireless
From: Ping-Ke Shih <pkshih@realtek.com>
This was detected with static analysis using Coccinelle:
./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1107:5-18:
duplicated argument to && or ||
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
index fd3b1fb35dff..05beb16f0a0a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
@@ -1104,7 +1104,7 @@ static void halbtc8723b1ant_ps_tdma(struct btc_coexist *btcoexist,
}
if ((type == 1) || (type == 2) || (type == 9) || (type == 11) ||
- (type == 101) || (type == 102) || (type == 109) || (type == 101)) {
+ (type == 101) || (type == 102) || (type == 109) || (type == 111)) {
if (!coex_sta->force_lps_on) {
/* Native power save TDMA, only for A2DP-only case
* 1/2/9/11 while wifi noisy threshold > 30
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle
2018-02-27 1:57 [PATCH] rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle pkshih
@ 2018-02-27 16:26 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-02-27 16:26 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: colin.king, Larry.Finger, yhchuang, linux-wireless
Ping-Ke Shih <pkshih@realtek.com> wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> This was detected with static analysis using Coccinelle:
>
> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c:1107:5-18:
> duplicated argument to && or ||
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
e28adf9ae63c rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle
--
https://patchwork.kernel.org/patch/10244103/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-27 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-27 1:57 [PATCH] rtlwifi: btcoex: fix argument typo of if-statement found by Coccinelle pkshih
2018-02-27 16:26 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).