* [PATCH] ssb: Prevent build of PCI host features in module
@ 2018-01-12 14:25 Matt Redfearn
2018-02-28 14:39 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Matt Redfearn @ 2018-01-12 14:25 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless, Matt Redfearn, linux-kernel
Attempting to build ssb.ko with CONFIG_SSB_DRIVER_PCICORE=y results in
a build error due to use of symbols not exported from vmlinux:
ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
To prevent this, don't allow the host mode feature to be built if
CONFIG_SSB=m
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
drivers/ssb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index d8e4219c2324..3e1c814e7331 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -118,7 +118,7 @@ config SSB_SERIAL
config SSB_DRIVER_PCICORE_POSSIBLE
bool
- depends on SSB_PCIHOST
+ depends on SSB_PCIHOST && SSB = y
default y
config SSB_DRIVER_PCICORE
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ssb: Prevent build of PCI host features in module
2018-01-12 14:25 [PATCH] ssb: Prevent build of PCI host features in module Matt Redfearn
@ 2018-02-28 14:39 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-02-28 14:39 UTC (permalink / raw)
To: Matt Redfearn; +Cc: Michael Buesch, linux-wireless, Matt Redfearn, linux-kernel
Matt Redfearn <matt.redfearn@mips.com> wrote:
> Attempting to build ssb.ko with CONFIG_SSB_DRIVER_PCICORE=y results in
> a build error due to use of symbols not exported from vmlinux:
>
> ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
> ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
>
> To prevent this, don't allow the host mode feature to be built if
> CONFIG_SSB=m
>
> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
Patch applied to wireless-drivers-next.git, thanks.
882164a4a928 ssb: Prevent build of PCI host features in module
--
https://patchwork.kernel.org/patch/10161131/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 14:25 [PATCH] ssb: Prevent build of PCI host features in module Matt Redfearn
2018-02-28 14:39 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).