* [PATCH] mt76x2: remove warnings in mt76x2_mac_write_txwi()
[not found] <cover.1517443974.git.lorenzo.bianconi@redhat.com>
@ 2018-02-01 0:27 ` Lorenzo Bianconi
2018-02-28 14:54 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2018-02-01 0:27 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless
Fix following sparse warnings in mt76x2_mac_write_txwi:
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: warning:
incorrect type in assignment (different base types)
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: expected
restricted __le32 [usertype] iv
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: got unsigned
int [unsigned] [usertype] <noident>
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: warning:
incorrect type in assignment (different base types)
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: expected
restricted __le32 [usertype] eiv
- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: got unsigned
int [unsigned] [usertype] <noident>
Fixes: 23405236460b ("mt76: fix transmission of encrypted management
frames")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
index 6c30b5eaa9ca..279cd8717806 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_mac.c
@@ -198,8 +198,8 @@ void mt76x2_mac_write_txwi(struct mt76x2_dev *dev, struct mt76x2_txwi *txwi,
ccmp_pn[5] = pn >> 24;
ccmp_pn[6] = pn >> 32;
ccmp_pn[7] = pn >> 40;
- txwi->iv = *((u32 *) &ccmp_pn[0]);
- txwi->eiv = *((u32 *) &ccmp_pn[1]);
+ txwi->iv = *((__le32 *)&ccmp_pn[0]);
+ txwi->eiv = *((__le32 *)&ccmp_pn[1]);
}
spin_lock_bh(&dev->mt76.lock);
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mt76x2: remove warnings in mt76x2_mac_write_txwi()
2018-02-01 0:27 ` [PATCH] mt76x2: remove warnings in mt76x2_mac_write_txwi() Lorenzo Bianconi
@ 2018-02-28 14:54 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-02-28 14:54 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Fix following sparse warnings in mt76x2_mac_write_txwi:
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: warning:
> incorrect type in assignment (different base types)
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: expected
> restricted __le32 [usertype] iv
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:201:26: got unsigned
> int [unsigned] [usertype] <noident>
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: warning:
> incorrect type in assignment (different base types)
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: expected
> restricted __le32 [usertype] eiv
> - drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:202:27: got unsigned
> int [unsigned] [usertype] <noident>
>
> Fixes: 23405236460b ("mt76: fix transmission of encrypted management frames")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
09e93f28aa8d mt76x2: remove warnings in mt76x2_mac_write_txwi()
--
https://patchwork.kernel.org/patch/10194957/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1517443974.git.lorenzo.bianconi@redhat.com>
2018-02-01 0:27 ` [PATCH] mt76x2: remove warnings in mt76x2_mac_write_txwi() Lorenzo Bianconi
2018-02-28 14:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).