From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
nbd@nbd.name, linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mt76: enable MAC80211_LEDS by default
Date: Wed, 21 Mar 2018 16:27:00 +0100 [thread overview]
Message-ID: <20180321152659.GA8108@localhost.localdomain> (raw)
In-Reply-To: <CAK8P3a1aHXPzvpZET=d2+snMPvsKx=rwfMN-r1_F2HK-KvjC0g@mail.gmail.com>
On Mar 21, Arnd Bergmann wrote:
> On Wed, Mar 21, 2018 at 6:45 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Fri, 2018-03-16 at 15:45 +0100, Lorenzo Bianconi wrote:
> >> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> >> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> >> @@ -1,5 +1,8 @@
> >> config MT76_CORE
> >> tristate
> >> + select MAC80211_LEDS
> >
> > Should drivers really mess with mac80211's configuration that way? I
> > believe this is a user-visible config, no?
>
> We have a couple of drivers using 'select LEDS_CLASS' and others
> doing 'depends on LEDS_CLASS'. I think the latter is what we should
> have here for all those drivers.
>
> MAC80211_LEDS looks like it's designed to be optional, so nothing
> should select or depend on that.
>
> Arnd
Reviewing the current code we do not actually need MAC80211_LEDS, so I agree
to remove it from Kconfig and let userspace selects the option. I would use
select for LEDS_CLASS. If you agree I can send a v2 otherwise I fine to apply
Arnd's patch.
Felix what do you think?
Regards,
Lorenzo
next prev parent reply other threads:[~2018-03-21 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1521209538.git.lorenzo.bianconi@redhat.com>
2018-03-16 14:45 ` [PATCH] mt76: enable MAC80211_LEDS by default Lorenzo Bianconi
2018-03-20 22:45 ` Johannes Berg
2018-03-21 6:59 ` Arnd Bergmann
2018-03-21 15:27 ` Lorenzo Bianconi [this message]
2018-03-22 1:59 ` Arnd Bergmann
2018-03-22 10:22 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321152659.GA8108@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=arnd@arndb.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).