From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
rfried@codeaurora.org, bjorn.andersson@linaro.org,
Daniel Mack <daniel@zonque.org>
Subject: Re: [v2] wcn36xx: dequeue all pending indicator messages
Date: Thu, 29 Mar 2018 08:59:06 +0000 (UTC) [thread overview]
Message-ID: <20180329085906.D25A860F8F@smtp.codeaurora.org> (raw)
In-Reply-To: <20180319062754.24464-1-daniel@zonque.org>
Daniel Mack <daniel@zonque.org> wrote:
> In case wcn36xx_smd_rsp_process() is called more than once before
> hal_ind_work was dispatched, the messages will end up in hal_ind_queue,
> but wcn36xx_ind_smd_work() will only look at the first message in that
> list.
>
> Fix this by dequeing the messages from the list in a loop, and only stop
> when it's empty.
>
> This issue was found during a review of the driver. In my tests, that
> race never actually occured.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
f276ba06e8b2 wcn36xx: dequeue all pending indicator messages
--
https://patchwork.kernel.org/patch/10291683/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-03-29 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 6:27 [PATCH v2] wcn36xx: dequeue all pending indicator messages Daniel Mack
2018-03-29 8:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329085906.D25A860F8F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@zonque.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).