* [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver
@ 2018-04-05 1:25 Gustavo A. R. Silva
2018-04-05 2:06 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-04-05 1:25 UTC (permalink / raw)
To: Yan-Hsuan Chuang, Ping-Ke Shih, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
Hi all,
While doing some static analysis I came across the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581:
1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist,
1582 u8 wifi_status)
1583 {
1584 /* tdma and coex table */
1585 btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC, true, 5);
1586
1587 if (BT_8821A_1ANT_WIFI_STATUS_NON_CONNECTED_ASSO_AUTH_SCAN ==
1588 wifi_status)
1589 btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);
1590 else
1591 btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);
1592 }
The issue here is that the code for both branches of the if-else statement is identical.
The if-else was introduced a year ago in this commit c6821613e653
I wonder if an argument should be changed in any of the calls to btc8821a1ant_coex_table_with_type?
What do you think?
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver
2018-04-05 1:25 [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver Gustavo A. R. Silva
@ 2018-04-05 2:06 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2018-04-05 2:06 UTC (permalink / raw)
To: 莊彥宣, kvalo@codeaurora.org,
gustavo@embeddedor.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
T24gVGh1LCAyMDE4LTA0LTA1IGF0IDAxOjI1ICswMDAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdy
b3RlOg0KPiBIaSBhbGwsDQo+IA0KPiBXaGlsZSBkb2luZyBzb21lIHN0YXRpYyBhbmFseXNpcyBJ
IGNhbWUgYWNyb3NzIHRoZSBmb2xsb3dpbmcgcGllY2Ugb2YgY29kZSBhdA0KPiBkcml2ZXJzL25l
dC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg4MjFhMWFudC5jOjE1
ODE6DQo+IA0KPiAxNTgxIHN0YXRpYyB2b2lkIGJ0Yzg4MjFhMWFudF9hY3RfYnRfc2NvX2hpZF9v
bmx5X2J1c3koc3RydWN0IGJ0Y19jb2V4aXN0ICpidGNvZXhpc3QsDQo+IDE1ODLCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB1OCB3aWZpX3N0YXR1cykNCj4gMTU4
MyB7DQo+IDE1ODTCoMKgwqDCoMKgwqDCoMKgwqAvKiB0ZG1hIGFuZCBjb2V4IHRhYmxlICovDQo+
IDE1ODXCoMKgwqDCoMKgwqDCoMKgwqBidGM4ODIxYTFhbnRfcHNfdGRtYShidGNvZXhpc3QsIE5P
Uk1BTF9FWEVDLCB0cnVlLCA1KTsNCj4gMTU4NsKgDQo+IDE1ODfCoMKgwqDCoMKgwqDCoMKgwqBp
ZiAoQlRfODgyMUFfMUFOVF9XSUZJX1NUQVRVU19OT05fQ09OTkVDVEVEX0FTU09fQVVUSF9TQ0FO
ID09DQo+IDE1ODjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHdpZmlfc3RhdHVzKQ0KPiAxNTg5
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJ0Yzg4MjFhMWFudF9jb2V4X3RhYmxl
X3dpdGhfdHlwZShidGNvZXhpc3QsIE5PUk1BTF9FWEVDLCAxKTsNCj4gMTU5MMKgwqDCoMKgwqDC
oMKgwqDCoGVsc2UNCj4gMTU5McKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBidGM4
ODIxYTFhbnRfY29leF90YWJsZV93aXRoX3R5cGUoYnRjb2V4aXN0LCBOT1JNQUxfRVhFQywgMSk7
DQo+IDE1OTIgfQ0KPiANCj4gVGhlIGlzc3VlIGhlcmUgaXMgdGhhdCB0aGUgY29kZSBmb3IgYm90
aCBicmFuY2hlcyBvZiB0aGUgaWYtZWxzZSBzdGF0ZW1lbnQgaXMgaWRlbnRpY2FsLg0KPiANCj4g
VGhlIGlmLWVsc2Ugd2FzIGludHJvZHVjZWQgYSB5ZWFyIGFnbyBpbiB0aGlzIGNvbW1pdCBjNjgy
MTYxM2U2NTMNCj4gDQo+IEkgd29uZGVyIGlmIGFuIGFyZ3VtZW50IHNob3VsZCBiZSBjaGFuZ2Vk
IGluIGFueSBvZiB0aGUgY2FsbHMgdG8NCj4gYnRjODgyMWExYW50X2NvZXhfdGFibGVfd2l0aF90
eXBlPw0KPiANCj4gDQoNCkl0IGxvb2tzIHdlaXJkLiBTaW5jZSB3ZSdyZSBpbiBzcHJpbmcgdmFj
YXRpb24sIEknbGwgY2hlY2sgbXkgY29sbGVhZ3VlIG5leHQgTW9uZGF5Lg0KDQpQSw0KDQo=
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-05 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-05 1:25 [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver Gustavo A. R. Silva
2018-04-05 2:06 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).