linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wcn36xx: Add missing fall through comment in smd.c
@ 2018-04-05 11:51 Loic Poulain
  2018-04-05 20:53 ` Bjorn Andersson
  2018-04-10 14:39 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Loic Poulain @ 2018-04-05 11:51 UTC (permalink / raw)
  To: kvalo; +Cc: linux-wireless, wcn36xx, dan.carpenter, Loic Poulain

This prevents GCC warning.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 7cc2928..7b79e0b 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -2135,6 +2135,7 @@ static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)
 	switch (rsp->type) {
 	case WCN36XX_HAL_SCAN_IND_FAILED:
 		scan_info.aborted = true;
+		/* fall through */
 	case WCN36XX_HAL_SCAN_IND_COMPLETED:
 		mutex_lock(&wcn->scan_lock);
 		wcn->scan_req = NULL;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wcn36xx: Add missing fall through comment in smd.c
  2018-04-05 11:51 [PATCH] wcn36xx: Add missing fall through comment in smd.c Loic Poulain
@ 2018-04-05 20:53 ` Bjorn Andersson
  2018-04-10 14:39 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2018-04-05 20:53 UTC (permalink / raw)
  To: Loic Poulain; +Cc: kvalo, wcn36xx, linux-wireless, dan.carpenter

On Thu 05 Apr 04:51 PDT 2018, Loic Poulain wrote:

> This prevents GCC warning.
> 

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
>  drivers/net/wireless/ath/wcn36xx/smd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 7cc2928..7b79e0b 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -2135,6 +2135,7 @@ static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)
>  	switch (rsp->type) {
>  	case WCN36XX_HAL_SCAN_IND_FAILED:
>  		scan_info.aborted = true;
> +		/* fall through */
>  	case WCN36XX_HAL_SCAN_IND_COMPLETED:
>  		mutex_lock(&wcn->scan_lock);
>  		wcn->scan_req = NULL;
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: wcn36xx: Add missing fall through comment in smd.c
  2018-04-05 11:51 [PATCH] wcn36xx: Add missing fall through comment in smd.c Loic Poulain
  2018-04-05 20:53 ` Bjorn Andersson
@ 2018-04-10 14:39 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-04-10 14:39 UTC (permalink / raw)
  To: Loic Poulain; +Cc: linux-wireless, wcn36xx, dan.carpenter, Loic Poulain

Loic Poulain <loic.poulain@linaro.org> wrote:

> This prevents GCC warning.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

1391cce7daf6 wcn36xx: Add missing fall through comment in smd.c

-- 
https://patchwork.kernel.org/patch/10324469/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-10 14:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-05 11:51 [PATCH] wcn36xx: Add missing fall through comment in smd.c Loic Poulain
2018-04-05 20:53 ` Bjorn Andersson
2018-04-10 14:39 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).