From: Jakub Kicinski <kubakici@wp.pl>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mt7601u: run calibration works after finishing scanning
Date: Fri, 13 Apr 2018 11:06:13 -0700 [thread overview]
Message-ID: <20180413110613.0c13f64f@cakuba.netronome.com> (raw)
In-Reply-To: <1523630678-8100-2-git-send-email-sgruszka@redhat.com>
On Fri, 13 Apr 2018 16:44:38 +0200, Stanislaw Gruszka wrote:
> When finishing scanning we switch to operational channel sill with
> SCANNING flag. This mean that we never perform calibration works after
> scanning. To fix the problem cancel and queue calibration works on
> .sw_scan_start() and .sw_scan_complete() routines.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
IOW the stack will potentially ask us to return to the original channel
before calling .sw_scan_complete()? Hm. That's unpleasant.
I'm not entirely on board with the patch. Now normal channel setting
will happen while calibration is running. Is that necessary? Would it
not be sufficient to make sure work is scheduled
from .sw_scan_complete()?
next prev parent reply other threads:[~2018-04-13 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 14:44 [PATCH 1/2] mt7601u: use EWMA to calculate avg_rssi Stanislaw Gruszka
2018-04-13 14:44 ` [PATCH 2/2] mt7601u: run calibration works after finishing scanning Stanislaw Gruszka
2018-04-13 18:06 ` Jakub Kicinski [this message]
2018-04-14 10:56 ` Stanislaw Gruszka
2018-04-16 18:45 ` Arend van Spriel
2018-04-13 18:06 ` [PATCH 1/2] mt7601u: use EWMA to calculate avg_rssi Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413110613.0c13f64f@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).