From: Kalle Valo <kvalo@codeaurora.org>
To: Maya Erez <merez@codeaurora.org>
Cc: Alexei Avshalom Lazar <ailizaro@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
Maya Erez <merez@codeaurora.org>
Subject: Re: [02/10] wil6210: set/get EDMG channel through debugfs
Date: Thu, 19 Apr 2018 16:15:06 +0000 (UTC) [thread overview]
Message-ID: <20180419161506.868FA60A06@smtp.codeaurora.org> (raw)
In-Reply-To: <1523520526-24997-3-git-send-email-merez@codeaurora.org>
Maya Erez <merez@codeaurora.org> wrote:
> Setting EDMG channel through debugfs for connect and PCP start
> commands.
Why? And what is an EDMG channel?
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why
I get bad vibes that this debugfs file is just a workaround for not adding this
to nl80211, a proper commit log would not give me such vibes in the first place :)
--
https://patchwork.kernel.org/patch/10338031/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-04-19 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 8:08 [PATCH 00/10] wil6210 patches Maya Erez
2018-04-12 8:08 ` [PATCH 01/10] wil6210: disable tracing config option Maya Erez
2018-04-12 8:08 ` [PATCH 02/10] wil6210: set/get EDMG channel through debugfs Maya Erez
2018-04-19 16:15 ` Kalle Valo [this message]
2018-04-22 12:40 ` [02/10] " merez
2018-04-24 9:47 ` Kalle Valo
2018-04-25 8:58 ` merez
2018-05-08 15:17 ` Kalle Valo
2018-04-12 8:08 ` [PATCH 03/10] wil6210: align to latest auto generated wmi.h Maya Erez
2018-04-12 8:08 ` [PATCH 04/10] wil6210: fix call to wil6210_disconnect during unload Maya Erez
2018-04-12 8:08 ` [PATCH 05/10] wil6210: change reply_size arg to u16 in wmi_call Maya Erez
2018-04-12 8:08 ` [PATCH 06/10] wil6210: use country specific board file upon reg domain change Maya Erez
2018-04-12 8:08 ` [PATCH 07/10] wil6210: move WMI functionality out of wil_cfg80211_mgmt_tx Maya Erez
2018-04-12 8:08 ` [PATCH 08/10] wil6210: Initialize reply struct of the WMI commands Maya Erez
2018-04-12 8:08 ` [PATCH 09/10] wil6210: remove unused rx_reorder members Maya Erez
2018-04-12 8:08 ` [PATCH 10/10] wil6210: rate limit wil_rx_refill error Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419161506.868FA60A06@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ailizaro@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).