* [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
@ 2018-04-03 20:30 Lorenzo Bianconi
2018-04-08 10:56 ` Felix Fietkau
2018-04-24 17:32 ` [v2] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2018-04-03 20:30 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless
Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
will be properly set according to the usage of an external power amplifier
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
Changes since v1:
- remove first initialization in order to have the writes to that register
grouped together in the same if/else chunk
---
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
index f28c55746cea..42414c5fa01e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
@@ -257,7 +257,6 @@ mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band)
mt76_wr(dev, MT_TX_ALC_CFG_2, 0x1b0f0400);
mt76_wr(dev, MT_TX_ALC_CFG_3, 0x1b0f0476);
}
- mt76_wr(dev, MT_TX_ALC_CFG_4, 0);
if (mt76x2_ext_pa_enabled(dev, band))
pa_mode_adj = 0x04000000;
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
2018-04-03 20:30 [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Lorenzo Bianconi
@ 2018-04-08 10:56 ` Felix Fietkau
2018-04-24 17:32 ` [v2] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2018-04-08 10:56 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless
On 2018-04-03 22:30, Lorenzo Bianconi wrote:
> Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
> will be properly set according to the usage of an external power amplifier
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
2018-04-03 20:30 [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Lorenzo Bianconi
2018-04-08 10:56 ` Felix Fietkau
@ 2018-04-24 17:32 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-04-24 17:32 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
> will be properly set according to the usage of an external power amplifier
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers-next.git, thanks.
cf7b411dcea8 mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
--
https://patchwork.kernel.org/patch/10321735/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-03 20:30 [PATCH v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration Lorenzo Bianconi
2018-04-08 10:56 ` Felix Fietkau
2018-04-24 17:32 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).