From: Barry Day <briselec@gmail.com>
To: Pkshih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac
Date: Sat, 28 Apr 2018 08:41:59 +1000 [thread overview]
Message-ID: <20180427224156.GA18163@thinktank.home.org> (raw)
In-Reply-To: <5B2DA6FDDF928F4E855344EE0A5C39D13BEBF231@RTITMBSV07.realtek.com.tw>
On Fri, Apr 27, 2018 at 05:44:16AM +0000, Pkshih wrote:
>
> The registers reside in driver causes error frequently, because MAC register
> is maintained by Realtek's MAC team so they create this module to avoid mistakes.
> Another benefit is to make it possible to become a thin driver, because many
> common functions are provided, so duplicate code will be reduced.
How is it possible to create a thin driver by adding lots more code and layers
of indirection ??? and writing it in a way that it won't compile without the
code for every type of bus interface even though most modules only use one ?
It's a horrible pile of garbage slapped together by an inexperienced
programmer. Its a major deterrent for anyone looking at working on one of
the latest realtek drivers.
next prev parent reply other threads:[~2018-04-27 22:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 2:08 [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac pkshih
2018-04-25 2:08 ` [PATCH v3 01/19] rtlwifi: add halmac structure to wifi.h pkshih
2018-04-25 2:08 ` [PATCH v3 02/19] rtlwifi: add debug ID COMP_HALMAC pkshih
2018-04-25 2:08 ` [PATCH v3 03/19] rtlwifi: add dmdef.h to share with driver and other modules pkshih
2018-04-25 2:08 ` [PATCH v3 04/19] rtlwifi: halmac: add main definition used by halmac pkshih
2018-04-25 2:08 ` [PATCH v3 05/19] rtlwifi: halmac: describe number and size of chip functions pkshih
2018-04-25 2:08 ` [PATCH v3 06/19] rtlwifi: halmac: add register definitions pkshih
2018-04-25 2:08 ` [PATCH v3 07/19] rtlwifi: halmac: add bit field definitions pkshih
2018-04-25 2:08 ` [PATCH v3 08/19] rtlwifi: halmac: add bit field definitions of rtl8822b pkshih
2018-04-25 2:08 ` [PATCH v3 09/19] rtlwifi: halmac: add definition of TX/RX descriptor pkshih
2018-04-25 2:08 ` [PATCH v3 10/19] rtlwifi: halmac: add GPIO pin/pinmux definitions pkshih
2018-04-25 2:08 ` [PATCH v3 11/19] rtlwifi: halmac: add power sequence to turn on/off wifi card pkshih
2018-04-25 2:08 ` [PATCH v3 12/19] rtlwifi: halmac: access efuse through halmac helper functions pkshih
2018-04-25 2:08 ` [PATCH v3 13/19] rtlwifi: halmac: add files to implement halmac ops pkshih
2018-04-25 2:08 ` [PATCH v3 14/19] rtlwifi: halmac: add halmac init/deinit functions pkshih
2018-04-25 2:08 ` [PATCH v3 15/19] rtlwifi: halmac: add firmware related functions and definitions pkshih
2018-04-25 2:08 ` [PATCH v3 16/19] rtlwifi: halmac: add bus interface commands pkshih
2018-04-25 2:08 ` [PATCH v3 17/19] rtlwifi: halmac: add to control WiFi mac functions and registers pkshih
2018-04-25 2:08 ` [PATCH v3 18/19] rtlwifi: halmac: add to support BB and RF functions pkshih
2018-04-25 2:08 ` [PATCH v3 19/19] rtlwifi: add halmac to Makefile and Kconfig pkshih
2018-04-25 7:36 ` [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac Kalle Valo
2018-04-27 5:44 ` Pkshih
2018-04-27 22:41 ` Barry Day [this message]
2018-04-30 2:40 ` Pkshih
2018-04-30 8:33 ` Krishna Chaitanya
2018-05-15 8:08 ` Pkshih
2018-05-16 12:36 ` Kalle Valo
2018-05-18 12:33 ` Pkshih
2018-05-24 8:27 ` Kalle Valo
2018-06-05 1:32 ` Pkshih
2018-06-29 8:38 ` New realtek 11ac driver Kalle Valo
2018-07-02 7:21 ` Dan Carpenter
2018-05-16 12:01 ` [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac Kalle Valo
2018-05-16 12:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427224156.GA18163@thinktank.home.org \
--to=briselec@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).